Fix/navbar dark class focus trap#50
Merged
SatyamPandey-07 merged 2 commits intoJul 5, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #48
in Navbar.tsx had two conflicting dark:bg-* utility classes (dark:bg-gray-800/95 and dark:bg-gray-900/95) on the same element — leftover from an incomplete edit, with Tailwind silently applying only the later one. Removed the dead dark:bg-gray-800/95 class, keeping dark:bg-gray-900/95. Separately, the mobile menu (#mobile-menu) closed on Escape and outside click but didn't trap Tab focus, so keyboard users could tab out of the open menu into content hidden behind the overlay. Extended the existing keydown effect to also handle Tab/Shift+Tab, cycling focus between the first and last focusable elements inside the menu, and moved initial focus into the menu when it opens. Both changes are contained to src/components/Navbar.tsx; no other files were touched.The