fix: add max attempts timeout to scan polling loop#49
Merged
SatyamPandey-07 merged 2 commits intoJul 5, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #47
Fixes the unbounded polling loop in useScanner.ts where scan() would call getReport every 3 seconds indefinitely if the backend never transitioned status away from in_progress (e.g. crash, hang, or stalled worker). Added a maxAttempts guard (100 attempts ≈ 5 minutes at the existing 3s interval) inside the while loop; once exceeded, it throws 'Scan timed out. Please try again.', which is caught by the existing catch block and surfaced via setError, while the existing finally block resets isScanning to false — so the UI correctly exits the "Scanning..." state with no additional state wiring required. Also added status, scanId, and identifier to the ScanResult interface in src/types/index.ts so the repeated inline as ScanResult & {...} casts in the hook could be removed.