Skip to content

fix(deps): stop Renovate bumping androidx past the compileSdk 36 pin #2235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
willgriffin wants to merge 1 commit into from
Closed

fix(deps): stop Renovate bumping androidx past the compileSdk 36 pin #2235

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions renovate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,18 @@
"matchFileNames": ["packages/*/template/package.json"],
"matchPackageNames": ["@happyvertical/smrt-*"],
"enabled": false
},
{
"description": "androidx.core 1.18+ and androidx.lifecycle 2.11+ require compileSdk 37, and both seed apps are pinned to compileSdk 36 (packages/smrt-android/AGENTS.md, and android-compile-sdk in each gradle/libs.versions.toml). The catalogs record that coupling in comments, which Renovate cannot read, so every weekly update bumped straight past it and left :sample:checkDebugAarMetadata failing on the whole PR (#2234). Remove these two rules in the same change that moves the toolchain to compileSdk 37.",
"matchManagers": ["gradle"],
"matchPackageNames": ["androidx.core:core-ktx"],
"allowedVersions": "<1.18"
},
{
"description": "See the androidx.core rule above — same compileSdk 36 coupling, androidx.lifecycle side (#2234).",
"matchManagers": ["gradle"],
"matchPackageNames": ["androidx.lifecycle:lifecycle-runtime-compose"],
"allowedVersions": "<2.11"
}
]
}
Loading