Open
Conversation
devinivy
reviewed
Feb 27, 2023
package.json
Outdated
Comment on lines
38
to
39
| "knex": ">=0.21.19", | ||
| "objection": ">=2 <4" |
Member
There was a problem hiding this comment.
Objection v3 is well over a year old, and it doesn't seem like v2 is going to receive updates anymore. Similar goes for knex— v1 came out over a year ago and v2 is actually out! If we're making a breaking change here, there would be something sort of nice/clean about supporting knex v0.95+ and objection v3+. Any thoughts/feels?
Member
Author
There was a problem hiding this comment.
Happy to bump both of those up. Also, since joi is at >=17 <18 will just simplify that down to ^17.0.0
devinivy
reviewed
Feb 27, 2023
package.json
Outdated
| "dependencies": { | ||
| "@hapi/hoek": "^9.0.0", | ||
| "@hapi/hoek": "^11.0.2", | ||
| "@hapipal/toys": "^3.2.0", |
Member
There was a problem hiding this comment.
Just released!
Suggested change
| "@hapipal/toys": "^3.2.0", | |
| "@hapipal/toys": "^4.0.0", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop support for older versions of node and bump peer deps accordingly.
Tests were failing with the old min versions of objection/knex from the peer deps, so I updated until I had what seem to be the min versions of each that will play nice with each other and still have all tests passing.