Skip to content

Replace :crypto.hmac_* with :crypto.mac_* on OTP >= 24 - #12

Open
mbklein wants to merge 1 commit into
handnot2:masterfrom
nulib:otp-24
Open

Replace :crypto.hmac_* with :crypto.mac_* on OTP >= 24#12
mbklein wants to merge 1 commit into
handnot2:masterfrom
nulib:otp-24

Conversation

@mbklein

@mbklein mbklein commented Jun 28, 2021

Copy link
Copy Markdown

The :crypto.hmac_* functions are no longer present in OTP 24. They've been replaced by :crypto.mac_* functions with almost identical functionality but a slightly different call signature for the init function. This PR includes a compile-time conditional that chooses the right crypto functions based on the OTP version.

@jfayad

jfayad commented Jul 14, 2021

Copy link
Copy Markdown

@handnot2 @zeroasterisk can you merge this PR and publish a new release of this library ? if your plate is full, can you add me as maintainer on both Github and Hex so I could do it ? I like to keep my deps declaration clean ;-)

thanks

@subaru9

subaru9 commented Jul 18, 2021

Copy link
Copy Markdown

Any updates here?

@zeroasterisk

Copy link
Copy Markdown
Contributor

Sorry, I'm not a maintainer, cannot help. @handnot2

@jfayad

jfayad commented Jul 20, 2021

Copy link
Copy Markdown

Thanks for the reply @zeroasterisk

@handnot2 can you please help unblock the situation here ?

@mbklein

mbklein commented Aug 5, 2021

Copy link
Copy Markdown
Author

@handnot2 hasn't had any Github activity of any kind recorded for nearly 2½ years, so I think the best option here might be to fork, rename, release, and try to inform downstream dependents of the new dependency name. I'm not in a position to take that on by myself, but I'd be happy to be included as a non-owner maintainer.

@mbklein

mbklein commented Nov 11, 2021

Copy link
Copy Markdown
Author

For anyone interested: @LetThereBeDwight has forked this repo, pulled in the changes, and published to hex as sigaws_otp_24.

@brooksmtownsend

Copy link
Copy Markdown

Thanks for this @LetThereBeDwight!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants