Replace :crypto.hmac_* with :crypto.mac_* on OTP >= 24 - #12
Conversation
|
@handnot2 @zeroasterisk can you merge this PR and publish a new release of this library ? if your plate is full, can you add me as maintainer on both Github and Hex so I could do it ? I like to keep my deps declaration clean ;-) thanks |
|
Any updates here? |
|
Sorry, I'm not a maintainer, cannot help. @handnot2 |
|
Thanks for the reply @zeroasterisk @handnot2 can you please help unblock the situation here ? |
|
@handnot2 hasn't had any Github activity of any kind recorded for nearly 2½ years, so I think the best option here might be to fork, rename, release, and try to inform downstream dependents of the new dependency name. I'm not in a position to take that on by myself, but I'd be happy to be included as a non-owner maintainer. |
|
For anyone interested: @LetThereBeDwight has forked this repo, pulled in the changes, and published to hex as sigaws_otp_24. |
|
Thanks for this @LetThereBeDwight! |
The
:crypto.hmac_*functions are no longer present in OTP 24. They've been replaced by:crypto.mac_*functions with almost identical functionality but a slightly different call signature for theinitfunction. This PR includes a compile-time conditional that chooses the right crypto functions based on the OTP version.