Repository navigation
Don't export TypeVars bound by tuple unpacking - #56
Merged
Merged
Conversation
`T, U = TypeVar("T"), TypeVar("U")` was not recognized because only a
Call assigned directly to the name was checked. The rule now follows the
target's position through nested tuple/list unpacking to its value.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019P9bvuGwAyVCNUdsAYPB1V
hakancelikdev
merged commit Sep 25, 2026
ebab1af
into
claude/issuelari-gorme-fpbbfd
26 checks passed
hakancelikdev
pushed a commit
that referenced
this pull request
Oct 2, 2026
- Bump the version to 0.5.0. - Date the changelog section and add the entries that were missing for #53, #54, #56, #57, #58, #60, #61 and #62. - Fix license_files: `file: LICENSE` is not a valid glob, so LICENSE was left out of the built sdist and wheel. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019P9bvuGwAyVCNUdsAYPB1V
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review finding on the integration branch (follow-up to #34).
Problem
_rule_name_not_type_varonly looked at a Call assigned directly to the name.T, U = TypeVar("T"), TypeVar("U")was therefore exported.Fix
New
_assigned_valuefollows the target's position through nested tuple/list unpacking to the matching value element. If the shapes don't match (e.g. unpacking a function result), it returnsNoneand the name is treated as before.Tests
test_type_var_is_not_publicnow coversA, (B, [C]) = TypeVar(...), (TypeVar(...), [TypeVar(...)]), and a mixedPair, Name = TypeVar("Pair"), "a string"whereNameis still exported. It fails without the fix. 3.10 / 3.12 / 3.14, pre-commit, mypy and the self-check all pass.🤖 Generated with Claude Code
https://claude.ai/code/session_019P9bvuGwAyVCNUdsAYPB1V
Generated by Claude Code