Skip to content

Handle exceptions when parsing 'retry-after' header in rate limit handling #4931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ludeeus wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Handle exceptions when parsing 'retry-after' header in rate limit handling #4931

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion custom_components/hacs/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -707,7 +707,10 @@ async def async_download_file(

# Handle rate-limits
if handle_rate_limit and request.status == 429:
header = int(request.headers.get("retry-after") or 10)
try:
header = int(request.headers.get("retry-after") or 10)
except (ValueError, TypeError):
header = 10
retry_after = min(header, 60) # Limit to 60 seconds

self.log.warning(
Expand Down
Loading