Repository navigation
Add trading - #75
Open
expanderbult wants to merge 1 commit into
Open
Add trading#75expanderbult wants to merge 1 commit into
expanderbult wants to merge 1 commit into
Conversation
Wrench a player > Trade, or /trade {player}, opens the real trade window. Both players add items, accept, and get a confirm dialog listing what they give and receive (with a scam warning when getting nothing back) before the items swap.
- Items are checked again right before the swap, so nothing can be duplicated or lost if an item disappears mid-trade.
- Untradeable items can't be offered, and a full backpack blocks the trade.
- Leaving the world or the game cancels the trade for both players.
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| Complexity | 8 medium |
🟢 Metrics 179 complexity · 1 duplication
Metric Results Complexity 179 Duplication 1
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrench a player > Trade, or /trade {player}, opens the real trade window. Both players add items, accept, and get a confirm dialog listing what they give and receive (with a scam warning when getting nothing back) before the items swap.