Repository navigation
Check permission and position in the lock, door and sign dialogs - #72
Open
expanderbult wants to merge 1 commit into
Open
expanderbult wants to merge 1 commit into
expanderbult wants to merge 1 commit into
Conversation
These dialogs trusted the tile position and the player. Anyone could send a lock_edit reply (with a modified client or proxy) and change any world's lock settings, edit doors and signs in locked worlds, or use a position outside the world, which writes outside world.blocks. lock_edit now needs the world owner and a lock at that position, door, sign and gateway edits need owner or access in locked worlds, positions are checked, and stoi() is replaced with atoi() so a missing checkbox can't throw and stop the server.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 13 |
| Duplication | -1 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These dialogs trusted the tile position and the player. Anyone could send a lock_edit reply (with a modified client or proxy) and change any world's lock settings, edit doors and signs in locked worlds, or use a position outside the world, which writes outside world.blocks. lock_edit now needs the world owner and a lock at that position, door, sign and gateway edits need owner or access in locked worlds, positions are checked, and stoi() is replaced with atoi() so a missing checkbox can't throw and stop the server.