Repository navigation
Fix dropped items turning into empty entries after a world reload - #64
Merged
Merged
Conversation
Loading resized the object list to last_object_uid, which keeps counting up as items are picked up, so the list filled with empty drops. The count now comes from the saved data size, an empty blob no longer gets read, and the world data sends the real drop count instead of last_object_uid twice.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
leeendl
self-requested a review
October 3, 2026 22:27
leeendl
reviewed
Oct 3, 2026
| int i{}; | ||
| memcpy(&this->last_object_uid, u8, sizeof(u_int)); i += sizeof(u_int); // @todo real gt has this as 8 bits not just 4. | ||
| if (blob.size() >= sizeof(u_int)) memcpy(&this->last_object_uid, u8, sizeof(u_int)); | ||
| i += sizeof(u_int); // @todo real gt has this as 8 bits not just 4. |
Member
There was a problem hiding this comment.
thank you! this was very clear. i'm sorry for one lining this and making it confusing. <3
leeendl
approved these changes
Oct 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Loading resized the object list to last_object_uid, which keeps counting up as items are picked up, so the list filled with empty drops. The count now comes from the saved data size, an empty blob no longer gets read, and the world data sends the real drop count instead of last_object_uid twice.