Repository navigation
Do not print login packets to the console - #62
Closed
expanderbult wants to merge 1 commit into
Closed
expanderbult wants to merge 1 commit into
expanderbult wants to merge 1 commit into
Conversation
The server printed every text packet, including logins with the password in plain text.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
leeendl
self-requested a review
October 3, 2026 22:24
leeendl
reviewed
Oct 3, 2026
| { | ||
| std::string header{data.begin() + 4, data.end() - 1}; | ||
| puts(header.c_str()); | ||
| if (header.find("password") == std::string::npos && header.find("ltoken|") == std::string::npos) puts(header.c_str()); // @note never print logins, they contain passwords |
Member
There was a problem hiding this comment.
respectfully this is useful for debugging so i will not merge this. thank you.
leeendl
reviewed
Oct 3, 2026
leeendl
left a comment
leeendl
left a comment
Member
There was a problem hiding this comment.
bad for debugging ltoken and login information.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The server printed every text packet, including logins with the password in plain text.