Repository navigation
chore(workspace): remove local device data generation - #268
Merged
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Certified Devices JSON へ移行済みのため、Dashboard 側の自前デバイス同期・生成処理を削除しました。ランタイムは引き続き
chirimen-certified-devices/generated/devices.jsonを参照します。Type of change
Related issues
What changed?
sync-devices/sync-example-upstreams/generate-platform-examples/validate-platform-examplesの Nx プロジェクトを削除しましたdata/example-upstreams/data/platform-examples/generated/reports/apps/web/public/devices.jsonを削除しましたrefresh-devices.ymlとdeploy.ymlは後続 Issue のため残しています)generate:devices等)と依存(axios/yaml/tsx)を削除し、lockfile を更新しましたAPI / Compatibility
ランタイムの Device Repository API は変更していません。ローカルの
pnpm generate:devicesなど自前生成コマンドは廃止です。refresh-devices.ymlは削除した scripts を呼び出すため、#259 merge 後〜#260 完了までは壊れた状態になります。親 Issue の実施順どおりです。How to test
pnpm nx show projectsに 4 つの同期・生成ツールが残っていないことを確認するpnpm build/pnpm test:all/pnpm lint:allが成功することを確認するpnpm start後、一覧・詳細が Certified Devices JSON から表示され、/devices.jsonが 404 になることを確認するEnvironment (if relevant)
Checklist
README / architecture / データ更新手順の本文更新は #262 で実施します。commitlint scope 表だけはこの PR で同期しています。
Made with Cursor