Repository navigation
test(web-e2e): adapt tests to certified devices json - #267
Merged
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Certified Devices JSON をデータソースにした後も、unit / E2E が外部ネットワークに依存せず安定して検証できるようにしました。
libs-data-accessの Device ID resolver にremoteDevicesalias の parse テストを追加page.routemock を追加Type of change
Related issues
What changed?
parseCertifiedAliasesがremoteDevicesを取り出せることを unit test で検証apps/web-e2e/src/fixtures/certified-devices.jsonを追加し、本番 GitHub JSON への fetch を Playwright で差し替えapps/web-e2e/src/example.spec.tsを削除API / Compatibility
How to test
pnpm nx test libs-data-accesspnpm nx e2e web-e2epnpm nx affected -t lint,build,test --base=mainE2E 実行時、ブラウザが
raw.githubusercontent.comの本番devices.jsonを取得せず、ローカル fixture を使うことを確認してください。Environment (if relevant)
Checklist
Made with Cursor