Repository navigation
fix(web): harden device ui for certified devices data - #266
Merged
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Certified Devices JSON をデータソースにした状態で、一覧・検索・詳細・Example UI を検証し、欠損・破損画像と空 category でレイアウトが崩れないよう修正しました。
Type of change
Related issues
What changed?
/no_image.pngへフォールバックする検証結果(live certified JSON、約 108 件):
ADS1015)と platform 別名(raspberry)が動作する。専用 category / tag フィルタ UI は既存どおり存在しないため追加していない/devices/ADS1015が表示され、/devices/i2c-ads1015は canonical URL へリダイレクトされるprimary/archive/incubator状態バッジを表示するAPI / Compatibility
How to test
pnpm exec nx serve webで http://localhost:4200/ を開くADS1015とraspberryを入力し、該当デバイスに絞り込まれることを確認する/devices/ADS1015と/devices/i2c-ads1015(canonical へリダイレクト)を開き、商品リンク・Example・datasheet / circuit を確認する/devices/SG90や Grove 系など画像 URL が壊れているデバイスで、壊れ画像ではなくプレースホルダが表示されることを確認する/devices/10kのように datasheet / circuit / reference が無いデバイスで、該当セクションが省略され詳細画面が成立することを確認するEnvironment (if relevant)
Checklist
Made with Cursor