Update CreateMeasurementsFast.java eliminating race condition #762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
preventing race conditions, accountable for broken file structure. why: Multiple writers open the same path with APPEND and write at the same time. Java’s BufferedWriter/OutputStreamWriter will encode and write the big string in multiple underlying writes, so chunks from different threads can interleave (and, in fact - it's exactly what was happening).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
preventing race conditions, accountable for broken file structure.
why:
Multiple writers open the same path with APPEND and write at the same time. Java’s BufferedWriter/OutputStreamWriter will encode and write the big string in multiple underlying writes, so chunks from different threads can interleave (and, in fact - it's exactly what was happening).