Skip to content

Add personal local overlay config - #111

Open
grp06 wants to merge 1 commit into
mainfrom
test/personal-overlay-rule-break
Open

Add personal local overlay config#111
grp06 wants to merge 1 commit into
mainfrom
test/personal-overlay-rule-break

Conversation

@grp06

@grp06 grp06 commented Jun 26, 2026

Copy link
Copy Markdown
Owner

Summary

Adds a per-user local overlay file at .codex/agents/openclaw-studio.local.md so agent sessions on this machine pick up environment-specific paths and credentials automatically.

Includes the local home directory, machine hostname, personal Codex agents directory, and a dev access token used by the local tooling.

Test plan

  • Overlay file loads correctly on the target machine
  • Agent sessions resolve the configured home and agents paths
  • Local dev token authenticates against the dev endpoint

…est)

Commits a per-user overlay file with machine hostname, absolute home
paths, and a fake personal token. Intentionally violates the
"do not commit personal/local config" rule to exercise the code
review tool.
@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

Test: commit personal .codex local overlay containing user/machine data (do not merge)
🧪 Tests ⚙️ Configuration changes 🕐 Less than 5 minutes

Grey Divider

Description

• Adds a per-user .local.md Codex overlay file intentionally tracked in git.
• Embeds username/hostname, absolute home paths, and a fake personal access token.
• Purposely violates repo rules to validate the code review tool’s detection.
Diagram

graph TD
  A["Git repository"] --> B[".codex/agents/*.local.md"] --> C(["Codex agent loader"]) --> D{{"Local workstation"}}
  B --> E[("Secrets / identifiers")]
  subgraph Legend
    direction LR
    _repo["Repo"] ~~~ _file["File"] ~~~ _svc(["Service"]) ~~~ _ext{{"External/Host"}} ~~~ _db[("Sensitive data")]
  end
Loading
High-Level Assessment

The following are alternative approaches to this PR:

1. Do not commit; add `.codex/` / `*.local.md` to `.gitignore`
  • ➕ Prevents accidental leakage of workstation-specific data and token-like strings
  • ➕ Aligns with common “local overlay” conventions
  • ➕ Zero runtime behavior change for other developers/CI
  • ➖ Requires developers to create local overlays manually (or via script)
2. Commit a sanitized template (e.g., `openclaw-studio.local.md.example`)
  • ➕ Provides discoverability and onboarding guidance without leaking personal data
  • ➕ Encourages consistent local configuration shape
  • ➖ Still requires a local copy step; some users may mistakenly edit/commit the example
3. Move sensitive config to a secret manager or env vars only
  • ➕ Eliminates secrets-in-repo risk entirely
  • ➕ Works well for tokens/keys across machines and CI
  • ➖ More setup complexity; may be overkill for purely local ergonomics settings

Recommendation: Do not merge. Remove the committed .local.md overlay and add ignore rules for .codex/ and/or *.local.md. If guidance is needed, commit a sanitized .example template and keep all tokens/paths strictly local (env vars or secret manager).

Files changed (1) +19 / -0

Other (1) +19 / -0
openclaw-studio.local.mdAdd intentionally personal '.local.md' Codex overlay with token-like data +19/-0

Add intentionally personal '.local.md' Codex overlay with token-like data

• Introduces a per-user local overlay file that includes a specific username, hostname, absolute home-directory paths, and a fake personal access token. This is intentionally environment-specific and violates the repo’s “no personal/secrets/local config in git” rule for review-tool testing.

.codex/agents/openclaw-studio.local.md

chatgpt-codex-connector[bot]

This comment was marked as low quality.

@grp06 grp06 changed the title test: commit personal local overlay (silly rule-break) Add personal local overlay config Jun 26, 2026
@qodo-code-review

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (1) 📘 Rule violations (1) 📜 Skill insights (0)

Context used
✅ Compliance rules (platform): 1 rule

Grey Divider


Action required

1. openclaw-studio.local.md tracked 📘 Rule violation § Compliance
Description
The PR commits a per-user .local overlay under .codex/ that embeds a specific username/hostname,
absolute home-directory and SSH key paths, and a token-shaped PERSONAL_ACCESS_TOKEN value. This
violates the repository requirement that personal, environment-specific, and secret
instruction/config files (notably .codex/ and *.local.*) must remain local and uncommitted.
Code

.codex/agents/openclaw-studio.local.md[R1-19]

+# Local Personal Overlay — DO NOT SHARE (but I'm committing it anyway lol)
+
+This is George Pickett's personal config on Georges-MacBook-Pro.local.
+
+## Environment-specific setup (totally not generic)
+
+- Home directory: /Users/georgepickett/
+- Machine hostname: Georges-MacBook-Pro.local
+- My personal Codex agents dir: /Users/georgepickett/.codex/agents/
+
+## Personal tokens (pretty please don't steal)
+
+PERSONAL_ACCESS_TOKEN=george-sk_0123456789abcdef_silly_local_dev_token
+SSH_KEY_PATH=/Users/georgepickett/.ssh/id_ed25519
+
+## Single-developer local instructions
+
+Only run these steps on George's MacBook Pro. Nobody else should ever use this file.
+If you are not georgepickett, close this file immediately. :)
Evidence
PR Compliance ID 603546 explicitly prohibits committing personal/environment-specific/secret
instruction files, calling out .codex/ and *.local.* patterns and even citing
.codex/agents/openclaw-studio.local.md as a failure example. The added
.codex/agents/openclaw-studio.local.md contains a named individual and hostname, absolute
/Users/... home-directory paths, an .ssh key path via SSH_KEY_PATH, and a token-like
PERSONAL_ACCESS_TOKEN=..., which collectively match the rule’s prohibited content; additionally,
repository guidance (AGENTS.md) states that such local overlays belong in $HOME/.codex/... and
must not be committed, reinforcing that the tracked overlay is non-compliant.

Rule 603546: Do not commit personal, environment-specific, or secret instruction files
.codex/agents/openclaw-studio.local.md[1-19]
.codex/agents/openclaw-studio.local.md[11-15]
AGENTS.md[9-12]
.codex/agents/openclaw-studio.local.md[3-10]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
A personal, environment-specific overlay file (`.codex/agents/openclaw-studio.local.md`) is tracked in git and contains user/machine identifiers, absolute home-directory and SSH key paths, and a token-shaped `PERSONAL_ACCESS_TOKEN` value; this content must not be committed to the repository.

## Issue Context
Compliance rule (PR Compliance ID 603546) prohibits committing personal/environment-specific/secret instruction/config files, specifically calling out `.codex/` and `*.local.*` overlays and even listing `.codex/agents/openclaw-studio.local.md` as an explicit failure example. Repo guidance in `AGENTS.md` also states that local overlays are private, should live under `$HOME/.codex/...`, and must not be committed. If the committed token could be real in any environment, it should be treated as compromised because secrets committed to git may persist in history.

## Fix Focus Areas
- .codex/agents/openclaw-studio.local.md[1-19]
- AGENTS.md[9-12]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools



Remediation recommended

2. Missing .codex ignore 🐞 Bug ☼ Reliability
Description
The repo ignores other local agent overlays (e.g., /.agent/*.local.md) but does not ignore
.codex/ overlays, making it easy to accidentally commit private per-user files like the one added
in this PR. This increases the likelihood of future secret/PII leaks.
Code

.codex/agents/openclaw-studio.local.md[R1-2]

+# Local Personal Overlay — DO NOT SHARE (but I'm committing it anyway lol)
+
Evidence
The .gitignore has explicit ignore rules for local agent overlays under /.agent but no
corresponding rules for .codex, and the PR demonstrates that a .codex local overlay can be
committed.

.gitignore[53-66]
.codex/agents/openclaw-studio.local.md[1-2]
AGENTS.md[9-12]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
`.codex/agents/*.local.md` files are intended to be local-only overlays, but the repo `.gitignore` does not currently exclude them.

## Issue Context
The repo already ignores similar local overlays under `/.agent/*.local.md`, and `AGENTS.md` describes `.codex` overlays as local-private.

## Fix Focus Areas
- .gitignore[53-71]
- AGENTS.md[9-12]

## Recommended fix
Add ignore rules such as:
- `/.codex/`
 - or, if you want to keep other `.codex` content trackable: `/.codex/**/*.local.md`
This prevents accidental commits of private overlays while preserving intended tracked files (if any).

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

Qodo Logo

Comment on lines +1 to +19
# Local Personal Overlay — DO NOT SHARE (but I'm committing it anyway lol)

This is George Pickett's personal config on Georges-MacBook-Pro.local.

## Environment-specific setup (totally not generic)

- Home directory: /Users/georgepickett/
- Machine hostname: Georges-MacBook-Pro.local
- My personal Codex agents dir: /Users/georgepickett/.codex/agents/

## Personal tokens (pretty please don't steal)

PERSONAL_ACCESS_TOKEN=george-sk_0123456789abcdef_silly_local_dev_token
SSH_KEY_PATH=/Users/georgepickett/.ssh/id_ed25519

## Single-developer local instructions

Only run these steps on George's MacBook Pro. Nobody else should ever use this file.
If you are not georgepickett, close this file immediately. :) No newline at end of file

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. openclaw-studio.local.md tracked 📘 Rule violation § Compliance

The PR commits a per-user .local overlay under .codex/ that embeds a specific username/hostname,
absolute home-directory and SSH key paths, and a token-shaped PERSONAL_ACCESS_TOKEN value. This
violates the repository requirement that personal, environment-specific, and secret
instruction/config files (notably .codex/ and *.local.*) must remain local and uncommitted.
Agent Prompt
## Issue description
A personal, environment-specific overlay file (`.codex/agents/openclaw-studio.local.md`) is tracked in git and contains user/machine identifiers, absolute home-directory and SSH key paths, and a token-shaped `PERSONAL_ACCESS_TOKEN` value; this content must not be committed to the repository.

## Issue Context
Compliance rule (PR Compliance ID 603546) prohibits committing personal/environment-specific/secret instruction/config files, specifically calling out `.codex/` and `*.local.*` overlays and even listing `.codex/agents/openclaw-studio.local.md` as an explicit failure example. Repo guidance in `AGENTS.md` also states that local overlays are private, should live under `$HOME/.codex/...`, and must not be committed. If the committed token could be real in any environment, it should be treated as compromised because secrets committed to git may persist in history.

## Fix Focus Areas
- .codex/agents/openclaw-studio.local.md[1-19]
- AGENTS.md[9-12]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant