Skip to content

fix: use minProtocol: 3 instead of args.protocol in connect params #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anschmieg wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: use minProtocol: 3 instead of args.protocol in connect params #103

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib/controlplane/gateway-connect-profile.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ export function buildGatewayConnectProfile(args: {
capabilities: string[];
}): GatewayConnectProfile {
const baseParams = {
minProtocol: args.protocol,
minProtocol: 3,
maxProtocol: args.protocol,
Comment on lines +79 to 80

Copilot AI Mar 27, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There doesn't appear to be a unit test asserting the connect request includes minProtocol/maxProtocol with the expected values (the existing tests/unit/openclawAdapter.test.ts inspects client and caps but not protocol params). Adding an assertion would prevent regressions like this from reappearing and matches the test plan described in the PR.

Copilot uses AI. Check for mistakes.
Comment on lines +79 to 80

Copilot AI Mar 27, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minProtocol is now hard-coded to 3 while maxProtocol still uses args.protocol. This can produce an invalid range (e.g., minProtocol > maxProtocol) if a caller passes anything other than 3, and it also creates a split source-of-truth for the protocol version. Consider deriving both fields from the same value (either use args.protocol for both, or hard-code both and remove/rename the protocol arg to avoid divergence).

Copilot uses AI. Check for mistakes.

@anschmieg anschmieg Mar 27, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot apply changes based on this feedback

role: "operator" as const,
scopes: [...OPERATOR_SCOPES],
Expand Down
Loading