feat: Removing /output wrapper project from CLI package.json template#111
Draft
szanata wants to merge 2 commits into
Draft
feat: Removing /output wrapper project from CLI package.json template#111szanata wants to merge 2 commits into
szanata wants to merge 2 commits into
Conversation
szanata
force-pushed
the
chore/remove_output_wrapper
branch
from
d1d5094 to
5139dc4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removing /output wrapper project from CLI package.json template.
TODO
This is a draft. It is still missing actual code removal and alterations to CLI's
updatecommand.Reasoning
When installing the SDK modules via a third party dependency (
@outputai/output), they all become indirect dependencies (only that is actually present in thepackage.json).So, when the code imports "core" or "http", it is actually importing dependencies of a dependency, which is an anti-pattern in NPM and package managing in general.