Skip to content

chore: add ci and fix build#54

Merged
bnchrch merged 7 commits into
mainfrom
chore/add-ci-and-fix-build
Apr 8, 2026
Merged

chore: add ci and fix build#54
bnchrch merged 7 commits into
mainfrom
chore/add-ci-and-fix-build

Conversation

@bnchrch

@bnchrch bnchrch commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Fix 10 TypeScript build errors introduced by commit a226ff2
  • Fix all 146 ESLint violations (trailing commas, let usage, unused imports, operator linebreaks, etc.)
  • Add readDetailed() to JinaClient to restore rich metadata (title, url, tokens) for 5 workflows that depended on the removed fetchBlogContent() API
  • Create missing src/shared/utils/html_renderer.ts for the ai_hn_digest newsletter workflow
  • Fix import paths in ai_hn_digest from shared/clients/ to clients/

Test plan

  • npm ci — lock file unchanged
  • npm run output:worker:build — 0 TypeScript errors
  • npm run lint — 0 ESLint errors

bnchrch added 2 commits April 8, 2026 13:27
Fix broken imports in ai_hn_digest (wrong shared/clients path), migrate
5 workflows from removed fetchBlogContent() to JinaClient.readDetailed(),
create missing html_renderer utility, and resolve all ESLint violations
(unused imports, let→const refactors, stylistic fixes).
Runs on every PR and push to main. Uses npm ci to enforce a frozen
lockfile, then verifies the build and lint both pass.
catsby and others added 2 commits April 8, 2026 16:07
Signed-off-by: Clint Shryock <clint@growthx.ai>
- blog_evaluator/steps.ts: import schemas from types.ts instead of
  redefining inline
- lead_enrichment_report: extract step input/output schemas to types.ts
- post_call_followup_drafter: extract step input schemas to types.ts
- sales_call_processor/workflow.ts: replace Promise.all with
  executeInParallel for proper SDK concurrency controls
bnchrch added 2 commits April 8, 2026 14:31
Apollo can return null for person name fields. Coerce to empty string
to satisfy the personProfileSchema which requires non-nullable strings.
The encrypted credentials.yml.enc was removed during open-source prep
but is needed for workflow execution. Updated .gitignore to allow the
encrypted file while still ignoring decryption keys.

@catsby catsby left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 minor suggestion, you are probably safe to ignore

Comment thread src/clients/jina.ts Outdated
Co-authored-by: Clint <catsby@users.noreply.github.com>
@bnchrch bnchrch merged commit f920036 into main Apr 8, 2026
1 check passed
@bnchrch bnchrch deleted the chore/add-ci-and-fix-build branch April 8, 2026 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants