ci: install Ruby before running bundler on the Android deploy - #15
Merged
Merged
Conversation
`deploy-android` has never succeeded. It runs `cd androidApp && bundle install` on `ubuntu-latest`, whose image ships no Ruby, so the step dies on `bundle: command not found` — including on the last green-ish run back in June 2025. The job was written for a self-hosted runner, where Ruby is already there: the file still carries `#[ self-hosted, unix ]` next to `runs-on`, and latexcards-app and controlresell-app both run this same fastlane setup on `guimauvedigital-github-runner-*` without any Ruby step. controlresell-app even keeps the fix written down, commented out, marked "Only on GH hosted runners". 3.3 is what that comment pins and what latexcards-app's Gemfile.lock records (`ruby 3.3.6p108`). Only the Android job changes. The iOS one fails for an unrelated reason — the key in MATCH_REPO_KEY is no longer authorized on groupeminaste/match — which is fixed outside this repository, and keeping the two apart is what makes the next run readable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
deploy-androidhas never succeeded, on any run. It doescd androidApp && bundle installonubuntu-latest, whose image ships no Ruby, so it dies onbundle: command not found— includingon the June 2025 run where iOS did go through.
The job was written for a self-hosted runner. The file still carries the evidence:
latexcards-app and controlresell-app run this same fastlane setup on
guimauvedigital-github-runner-*and need no Ruby step, because those machines have it.controlresell-app even keeps the fix in the file, commented out and labelled "Only on GH hosted
runners". This is that block, uncommented.
3.3is the version that comment pins, and what latexcards-app'sGemfile.lockrecords(
ruby 3.3.6p108).Only Android
The iOS job fails for an unrelated reason: the key in
MATCH_REPO_KEYis no longer authorized ongroupeminaste/match, which has no deploy key at all today. Its counterpart onguimauvedigital/match— created November 2024, read-only — was last used this morning, which iswhat keeps the other two apps deploying.
That is fixed outside this repository, by registering a deploy key. Keeping it out of this PR is
deliberate: after the merge, each job's outcome points at exactly one cause.
Expected after merge
deploy-androidgets pastbundle install. Whether it then uploads depends on the Play Storecredentials, which have never been exercised — this is the first time the job will reach fastlane
at all, so a failure past this point would be new information rather than the same old one.
deploy-iospasses only if the deploy key is in place.Note the Android job also assembles only the flavor being distributed now (
bundleProductionReleaserather than
bundleRelease), which came with the migration PR — otherwise it would also build thelocalflavor, which exists purely to talk to a backend on a developer's machine.