/api/v1/system/logs: Support binary-data in journal-entries.#57
Open
umgfoin wants to merge 1 commit intogrommunio:masterfrom
Open
/api/v1/system/logs: Support binary-data in journal-entries.#57umgfoin wants to merge 1 commit intogrommunio:masterfrom
umgfoin wants to merge 1 commit intogrommunio:masterfrom
Conversation
Fixes grommunio#56. Signed-off-by: umgfoin <umgfoin@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt UTF-8-encoding or (ignore unprintable) for binary-logdata (BLOB).
journalctl masks binary log data as [xxxB blob data]:
Nov 25 13:56:00 localhost imap[2795947]: [53B blob data]This patch attempts to encode logged binary-data in UTF-8 and makes it displayable using
decode("UTF-8", "ignore").In my opinion, this increases information density in cases where binary data still contain readable text:[2025-11-25 13:56:00.201637]: [::ffff:xxx.xxx.xxx.xxx]:20648 < ��� A� +|N�� 8րK ];>F^: ret=0h code=0Fixes #56