merge some modifications into a new composite

[Mathieu-Deharbe]

PR Summary

merge some modifications into a new composite

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/test/java/org/gridsuite/study/server/NetworkModificationTest.java`:
- Around line 2158-2163: The test currently only asserts the POST to
"/v1/network-composite-modifications/composite-modification" was called; update
the assertion to also verify the request body contains the expected modification
UUIDs produced by NetworkModificationService.mergeModificationsIntoComposite.
Build the same expectedBody map/JSON used in testInsertComposite (or mirror its
structure) and call the overload of WireMockUtilsCriteria.verifyPostRequest that
accepts an expected body (or use the equivalent body-verifying helper used for
verifyPutRequest) to assert the payload matches the expected modification UUID
list; ensure you reference the same endpoint and request-count arguments as
before.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c18d804c-0ba6-4ed7-87d2-423e997c4b08

📥 Commits

Reviewing files that changed from the base of the PR and between 2eb2141 and 086eb96.

📒 Files selected for processing (2)

• src/main/java/org/gridsuite/study/server/service/RebuildNodeService.java
• src/test/java/org/gridsuite/study/server/NetworkModificationTest.java

[coderabbitai]

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Verify the request body sent to the composite-modification endpoint.

The test verifies that the WireMock POST endpoint was called, but does not verify that the correct modification UUIDs were sent in the request body. According to the service layer contract, NetworkModificationService.mergeModificationsIntoComposite should POST the modification UUIDs to the downstream API. Similar tests in this file (e.g., testInsertComposite at lines 2106-2116) construct an expected body and verify it was sent.

🧪 Suggested enhancement to verify request body

+        String expectedBody = mapper.writeValueAsString(modificationUuids);
+
         WireMockUtilsCriteria.verifyPostRequest(
                 wireMockServer,
                 "/v1/network-composite-modifications/composite-modification",
                 Map.of(),
+                expectedBody,
                 1
         );

Note: You may need to verify the actual signature of WireMockUtilsCriteria.verifyPostRequest to ensure it accepts a body parameter. If the current overload only accepts URL, query params, and count, you might need to use a different verification method that includes body matching, similar to how testInsertComposite uses WireMockUtilsCriteria.verifyPutRequest with an expectedBody parameter.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/test/java/org/gridsuite/study/server/NetworkModificationTest.java` around
lines 2158 - 2163, The test currently only asserts the POST to
"/v1/network-composite-modifications/composite-modification" was called; update
the assertion to also verify the request body contains the expected modification
UUIDs produced by NetworkModificationService.mergeModificationsIntoComposite.
Build the same expectedBody map/JSON used in testInsertComposite (or mirror its
structure) and call the overload of WireMockUtilsCriteria.verifyPostRequest that
accepts an expected body (or use the equivalent body-verifying helper used for
verifyPutRequest) to assert the payload matches the expected modification UUID
list; ensure you reference the same endpoint and request-count arguments as
before.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud