Skip to content

Guarantee findAllChildrenUuids results order#809

Merged
Meklo merged 30 commits into
mainfrom
marcellinh/fix-findAllChildrenUuids-result-order
May 12, 2026
Merged

Guarantee findAllChildrenUuids results order#809
Meklo merged 30 commits into
mainfrom
marcellinh/fix-findAllChildrenUuids-result-order

Conversation

@Meklo
Copy link
Copy Markdown
Contributor

@Meklo Meklo commented Apr 29, 2026

PR Summary

Mathieu-Deharbe and others added 17 commits April 23, 2026 10:04
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
…omposites to groups

Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 29, 2026

Warning

Rate limit exceeded

@Meklo has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 44 minutes and 23 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: cbd668d2-46e1-49ef-8656-30d47825459c

📥 Commits

Reviewing files that changed from the base of the PR and between 658bcb3 and fd55a13.

📒 Files selected for processing (1)
  • src/main/java/org/gridsuite/modification/server/repositories/ModificationRepository.java

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Meklo and others added 8 commits April 30, 2026 11:00
…sites' into marcellinh/fix-findAllChildrenUuids-result-order
…sub_modificationsPK

Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
…sites' into marcellinh/fix-findAllChildrenUuids-result-order
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
@NativeQuery("WITH RECURSIVE ModificationHierarchy (modification_id, path) AS ( " +
" SELECT cast(:compositeUuid AS VARCHAR), ARRAY[0] " +
" UNION ALL " +
" SELECT cast(sm.modification_id AS VARCHAR), mh.path || (m.modifications_order + 1) " +
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the "+ 1" is useful :

Suggested change
" SELECT cast(sm.modification_id AS VARCHAR), mh.path || (m.modifications_order + 1) " +
" SELECT cast(sm.modification_id AS VARCHAR), mh.path || m.modifications_order " +

" INNER JOIN ModificationHierarchy mh ON m.id = mh.id " +
") " +
"SELECT distinct cast(m.id AS VARCHAR) FROM ModificationHierarchy m ")
@NativeQuery("WITH RECURSIVE ModificationHierarchy (modification_id, path) AS ( " +
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add a small comment like :
// returns the composite uuid and its children and subchildren's uuids
because the request is a bit complicated and it is not very logical that compositeUuid is returned given the function name (findAllChildrenUuids).

Base automatically changed from use-modifications_order-for-coposites to main May 12, 2026 13:14
@sonarqubecloud
Copy link
Copy Markdown

@Meklo Meklo merged commit fc4912f into main May 12, 2026
5 checks passed
@Meklo Meklo deleted the marcellinh/fix-findAllChildrenUuids-result-order branch May 12, 2026 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants