Skip to content

allow to use vsc filter for electronics cluster for sc computation#1130

Merged
EtienneLt merged 2 commits into
mainfrom
use-vsc-for-electronics-sc-computation
May 15, 2026
Merged

allow to use vsc filter for electronics cluster for sc computation#1130
EtienneLt merged 2 commits into
mainfrom
use-vsc-for-electronics-sc-computation

Conversation

@EtienneLt
Copy link
Copy Markdown
Contributor

PR Summary

Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
@EtienneLt EtienneLt self-assigned this May 13, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 13, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a021e913-5874-4de3-94e4-f7db7b0a8c99

📥 Commits

Reviewing files that changed from the base of the PR and between 98c3ad8 and f78ad1a.

📒 Files selected for processing (2)
  • src/components/parameters/short-circuit/columns-definition.ts
  • src/components/parameters/short-circuit/short-circuit-icc-cluster-table-cell.tsx

📝 Walkthrough

Walkthrough

This PR adds HVDC support to short-circuit ICC cluster parameters. The column definition for ICC cluster filtering now accepts VSC converter stations, and the UI dropdown for ICC cluster type selection includes HVDC as an option alongside generators.

Changes

Add HVDC support to short-circuit ICC cluster parameters

Layer / File(s) Summary
HVDC support in equipment types and UI options
src/components/parameters/short-circuit/columns-definition.ts, src/components/parameters/short-circuit/short-circuit-icc-cluster-table-cell.tsx
Equipment type filtering for ICC cluster filters now includes EquipmentType.VSC_CONVERTER_STATION, and the SHORT_CIRCUIT_ICC_CLUSTER_TYPE SelectInput options expanded to include HVDC alongside GENERATOR.

Suggested Reviewers

  • ayolab
  • souissimai
🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is empty, providing no information about the changeset. An empty description fails the basic requirement that it be related to the changeset in some way. Add a brief description explaining what the change does, why it was made, and any relevant testing or migration notes for reviewers.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: adding VSC (Voltage Source Converter) filter support for electronics cluster in short-circuit computation, which aligns with the code changes adding EquipmentType.VSC_CONVERTER_STATION.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

@EtienneLt EtienneLt merged commit 99cff39 into main May 15, 2026
6 checks passed
@EtienneLt EtienneLt deleted the use-vsc-for-electronics-sc-computation branch May 15, 2026 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants