Merged
Conversation
BrainBacon
force-pushed
the
fix/debugger
branch
from
7a5e45f to
268c599
Compare
girtonman
approved these changes
Dec 9, 2024
Contributor
girtonman
left a comment
girtonman
left a comment
There was a problem hiding this comment.
Looks good to me.
One small thing to address before merge: In cargo.toml, dbg_breakpoint is pinned to 0.1.1 instead of 0.1.0. Either the PR description or the code needs updating.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the ability to check for debuggers using the functionality from the dbg_breakpoint crate.
That crate doesn't have any ecosystem usage currently, but it comes from a PR that was merged into Rust and then reverted later.
I've audited the crate source and pinned the
0.1.1version to avoid any possible supply-chain attacks since the crate is so small and new.Additionally I added a cache for the debugger presence result and added a feature
no_cache_debuggerto skip the cache.