issue 21: parse floats in scientific notation#22
Merged
Conversation
Extends the number parser to accept exponent notation like `1e5`,
`1.5E-3`, and `2e+10`, in addition to plain decimal floats.
Also changes the `FloatingPoint` variant of `Number.Outcome` to carry
`{ val : Float, text : String }` instead of a bare `Float`, so the
original source representation is preserved alongside the parsed value.
This is useful for formatting and code generation, where we need to
know the author's original represenation.
Member
|
Thank you <3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends the number parser to accept exponent notation like
1e5,1.5E-3, and2e+10, in addition to plain decimal floats.Also changes the
FloatingPointvariant ofNumber.Outcometo carry{ val : Float, text : String }instead of a bareFloat, so the original source representation is preserved alongside the parsed value. This is useful for formatting and code generation, where we need to know the author's original represenation.