Skip to content

Disable unsafe yaml loading - #6774

Merged
eanders merged 5 commits into
mainfrom
ea-9101-yaml-safe
Aug 3, 2026
Merged

Disable unsafe yaml loading#6774
eanders merged 5 commits into
mainfrom
ea-9101-yaml-safe

Conversation

@eanders

@eanders eanders commented Jul 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Merging this PR

  • use the squash-merge strategy for PRs targeting main

Description

WIP

Type of change

Checklist before requesting review

  • I performed a self-review of my code
  • I ran the OP review skill
  • I ran the code that is being changed under ideal conditions, and it doesn't fail
  • If adding a new endpoint / exposing data in a new way, I have:
    • ensured the API can't leak data from other data sources
    • ensured this does not introduce N+1s
    • ensured permissions and visibility checks are performed in the right places
  • Any major architectural changes are supported by an approved ADR (Architectural Decision Record)
  • I updated the documentation (or not applicable)
  • I added spec tests (or not applicable)
  • I provided testing instructions in this PR or the related issue (or not applicable)

eanders
eanders commented Jul 29, 2026
View reviewed changes
Comment thread drivers/hmis/spec/support/shared_examples/versioning_and_paranoia.rb
raise('define let(:build_record) to use versioned model shared examples') unless defined?(build_record)

PaperTrailHelper.with_paper_trail do
PaperTrail.request.enabled = true

@eanders eanders Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a bunch of paper trail test related changes as the deserialization tests exposed that we weren't always using our with_paper_trail blocks, but we should have been.

@eanders
eanders marked this pull request as ready for review July 29, 2026 20:12
@eanders
eanders requested a review from ttoomey July 30, 2026 00:25
ttoomey
ttoomey approved these changes Aug 3, 2026
View reviewed changes

@ttoomey ttoomey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Comment thread app/controllers/warehouse_reports/hmis_exports_controller.rb Outdated
Comment thread app/models/grda_warehouse/cohort.rb Outdated
@eanders
eanders merged commit 7f90ada into main Aug 3, 2026
24 of 26 checks passed
@eanders
eanders deleted the ea-9101-yaml-safe branch August 3, 2026 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ttoomey ttoomey ttoomey approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eanders @ttoomey