Skip to content

[#9395] LSA CI - #6740

Merged
eanders merged 11 commits into
mainfrom
ea-9395-lsa-ci
Aug 3, 2026
Merged

[#9395] LSA CI#6740
eanders merged 11 commits into
mainfrom
ea-9395-lsa-ci

Conversation

@eanders

@eanders eanders commented Jul 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Merging this PR

  • use the squash-merge strategy for PRs targeting main

Description

  • Adds CI for LSA test coverage
  • Needs AWS_S3_ACTIONS_LSA_SAMPLE_PATH_FY_2026 set to indicate the path to the sample data

Type of change

  • New feature

Checklist before requesting review

  • I performed a self-review of my code
  • I ran the OP review skill
  • I ran the code that is being changed under ideal conditions, and it doesn't fail
  • If adding a new endpoint / exposing data in a new way, I have:
    • ensured the API can't leak data from other data sources
    • ensured this does not introduce N+1s
    • ensured permissions and visibility checks are performed in the right places
  • Any major architectural changes are supported by an approved ADR (Architectural Decision Record)
  • I updated the documentation (or not applicable)
  • I added spec tests (or not applicable)
  • I provided testing instructions in this PR or the related issue (or not applicable)

@eanders
eanders marked this pull request as ready for review August 3, 2026 13:08
@eanders
eanders requested a review from dtgreiner August 3, 2026 13:40
dtgreiner
dtgreiner reviewed Aug 3, 2026
View reviewed changes
Comment thread .github/workflows/lsa_integration_test.yml
dtgreiner
dtgreiner approved these changes Aug 3, 2026
View reviewed changes

@dtgreiner dtgreiner left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, but LGTM. Thanks!

@eanders @dtgreiner
Update .github/workflows/lsa_integration_test.yml
ff70277 
Co-authored-by: Dave G <149399758+dtgreiner@users.noreply.github.com>
@eanders
eanders merged commit d76f186 into main Aug 3, 2026
26 of 27 checks passed
@eanders
eanders deleted the ea-9395-lsa-ci branch August 3, 2026 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dtgreiner dtgreiner dtgreiner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eanders @dtgreiner