Skip to content

Propose UI notice for stale opportunities - #1320

Merged
martha merged 3 commits into
release-190from
mke/8363-stale-opp-util
Nov 18, 2025
Merged

Propose UI notice for stale opportunities#1320
martha merged 3 commits into
release-190from
mke/8363-stale-opp-util

Conversation

@martha

@martha martha commented Nov 12, 2025

Copy link
Copy Markdown
Contributor

Description

Following up from this thread, this PR adds an Alert on the Unit page if the opportunity is active, but the rules are out of date.

  • For now, this won't come up frequently because we are managing rules on the backend, so when we make updates to rules we should remember to refresh open opportunities.
  • But, I was thinking that in the future, when we make rules manageable in the UI, we likely will provide the user with some control over whether opportunities get refreshed or not. If they choose not to refresh opportunities, then I think this kind of alert could be helpful for reminding them of why the ruleset listed here may differ from the ruleset listed on the parent Unit Group page.
  • We can definitely workshop the language.
    • "stop and re-start" is a little clunky
    • I also thought about drafting some language along the lines of "the same might also be true for other units in the unit group, so you can also go back up one level to the unit page and do this operation in bulk" (obviously phrased more gracefully than that!), but I think it might be better to just keep it simple.
    • edited to add: perhaps we should also make it clearer that "the requirements may be out of date" = that means the client list might also be outdated
Screenshot 2025-11-12 at 5 17 02 PM

Type of change

New feature

Checklist before requesting review

  • I have performed a self-review of my code
  • I have run the code that is being changed under ideal conditions, and it doesn't fail
  • My code includes comments and/or descriptive variable names to help other engineers understand the intent (or not applicable)
  • My code follows the style guidelines of this project (eslint)
  • I have updated the documentation (or not applicable)
  • If it's not obvious how to test this change, I have provided testing instructions in this PR or the related issue

@martha
martha changed the base branch from release-189 to release-190 November 14, 2025 22:18
@martha
martha marked this pull request as ready for review November 14, 2025 22:27
@martha
martha requested a review from gigxz November 14, 2025 22:27
Comment on lines +97 to +99
This unit is stale, so the requirements below may appear out of
date. To bring them up to date, stop and then re-start accepting
referrals.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about:

The requirements below may be outdated. To refresh them, stop and re-start accepting referrals for this unit.

I think "stale" language might not be clear, and also want to clarify the action that must be taken on the unit.

@gigxz gigxz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Tested stopping and re-starting from the unit page

@martha
martha merged commit 048b466 into release-190 Nov 18, 2025
4 checks passed
@martha
martha deleted the mke/8363-stale-opp-util branch November 18, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants