[#8986] Cancel and Decline Reasons Move to the DB - #1140
Open
eanders wants to merge 11 commits into
Open
Conversation
eanders
commented
Jul 31, 2026
Comment on lines
-144
to
-150
| if contact&.user&.can_act_on_behalf_of_match_contacts? | ||
| combined_reasons | ||
| elsif contact.in?(match.shelter_agency_contacts) | ||
| shelter_agency_contact_reasons | ||
| else | ||
| hsa_contact_reasons | ||
| end |
Contributor
Author
There was a problem hiding this comment.
Note, this is the one place we have the ability to decline a match by two contact types and they are presented with different lists of reasons. We accomplish this with the audience column. I was tempted to simply leave that off since very few installations are still using the default route, but I can see how this might be a useful feature and didn't add too much complexity.
eanders
marked this pull request as ready for review
July 31, 2026 13:47
Contributor
Author
|
@dtgreiner sorry for the big PR, but MOST of it is just deleting things. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merging this PR
Description
MatchDecisionStep,MatchDecisionReasonAssignment), scoped per route and per step./admin/match_decision_reasons) and per-route/per-step reason assignments, embedded directly on the route edit page.match_decisions(decline_reason_text,administrative_cancel_reason_text) at decision time, so renaming a catalog reason no longer rewrites historical warehouse/reporting data.Warehouse::BuildReport#explainto read the new snapshot columns instead of the live reason association (the actual bug this denormalization was needed for).cas_seeds:backfill_match_decision_reason_assignments, run on every deploy, marked for removal once fully rolled out) that reconstructs the old hardcoded lists into the new tables; delete the now-obsolete concerns and per-step overrides once backfilled.CLIENT_REJECTEDorPROVIDER_REJECTEDper reason, with override at the step or per-route-assignment level (effective_referral_result), wired into CE APR reporting (Warehouse::ReferralEvent)./admin/match_routesindex (tabs for active/inactive routes, trimmed columns) and the route edit page (inline decline/cancel reasons table, breadcrumbs) for clarity.Type of change
Checklist before requesting review