Vacancy Submission Epic - #1109
Draft
eanders wants to merge 45 commits into
Draft
Conversation
* Fix XSS by moving to stimulus controller; rubocop fixups; centralize logic in models * Use store_accessor to cleanup accessing the JSON blob, move logic out of views * Fix JS in dev so hot reloading works * Align some more styles and form details; update style guide * Enforce that a sub-program belongs to the program * DRY up controller * Fix form error display * Expose the user's name * Test for generic error string * Review feedback * Better sizing of search/filter
Initial commit for vacancies update
[#9305] Vacancy Submission 01 - Updates to rules for better variable support
[#9305] Vacancy Submissions 02 - Updated Requirements manager
[#9305] Vacancy Submission 03 - Housing attributes and amenities
[#9305] Vacancy Submission 04 - Submission form
…anup [#9305] Vacancy Submission 05 - Rule and other cleanup
* Vacancy Submission approval workflow implementation * Add a link to the program * Add a backlink to units in the draft show page * Feature flag * Exclude closed sub-programs from vacancy creation forms * Make rubocop happy
* Vacancy Submission approval workflow implementation * Add a link to the program * Add a backlink to units in the draft show page * Feature flag * Exclude closed sub-programs from vacancy creation forms * Make rubocop happy * Harden vacancy approval * Fix casing for config * Fix bug in building create when rule includes error * Fix variable requirement on vacancy form * Copy building attributes to units on creation * Missed frozen string literal
* Use real buildings instead of addresses * Implement weighting rules; fix link to sub-program * Notifications for vacancy submissions * Test updates * Sanitize output of the markdown helper
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merging this PR
Description
This introduces a new workflow for submitting vacancies. It includes draft submissions, review and approval.
We'll retarget
release-104or later.Type of change
Checklist before requesting review