Bump phpunit/phpunit from 7.5.20 to 8.5.52#68
Merged
Conversation
Bumps [phpunit/phpunit](https://github.com/sebastianbergmann/phpunit) from 7.5.20 to 8.5.52. - [Release notes](https://github.com/sebastianbergmann/phpunit/releases) - [Changelog](https://github.com/sebastianbergmann/phpunit/blob/8.5.52/ChangeLog-8.5.md) - [Commits](sebastianbergmann/phpunit@7.5.20...8.5.52) --- updated-dependencies: - dependency-name: phpunit/phpunit dependency-version: 8.5.52 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
PHPUnit 8 requires setUp() and tearDown() to declare a void return type, otherwise the test run fails with a fatal error. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
PHPUnit 8 writes a .phpunit.result.cache file to the project root to speed up subsequent runs. It is local-only state and should not be tracked. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The Travis app is no longer connected, so the required
continuous-integration/travis-ci check has stopped reporting and
blocks every PR. Replace .travis.yml with an equivalent GitHub
Actions workflow:
- Matrix on PHP 7.2/7.3/7.4 x prefer-lowest (true/false)
- Nightly PHP kept as an allowed-failure (experimental) entry
- Composer cache via actions/cache
- phpcs + phpunit (with clover coverage) per matrix entry
- Scrutinizer coverage upload retained, gated to push events
on a single matrix combination
- make test-functional moved to its own job (uses docker-compose
preinstalled on ubuntu-latest runners)
Branch protection on master still requires the
continuous-integration/travis-ci context and must be updated to the
new check names ("PHP 7.4", "Functional tests", etc.) before this
unblocks merging.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Two unrelated issues surfaced once tests actually started running on every PR again (Travis had stopped reporting some time ago): - src/Parse/CollationInfo.php used str_contains(), a PHP 8.0+ function, but composer.json requires PHP ^7.2. The non-lowest matrix happened to pull symfony/polyfill-php80 transitively, but the lowest matrix did not, and the function was undefined at runtime. Replaced with strpos(...) !== false, which works on every supported PHP version with no extra dependency. - The functional-tests job invokes docker-compose via the Makefile, but ubuntu-latest runners no longer ship the legacy v1 binary; only the docker compose v2 plugin is installed. Added a small shim at /usr/local/bin/docker-compose that forwards to docker compose so the existing Makefile keeps working unchanged. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
- Drop PHP nightly from matrix: PHP 8.6-dev cannot satisfy the project's php ^7.2 constraint, so composer install always fails. GitHub Actions has no neutral indicator for allowed-failure jobs (unlike Travis), so removing it avoids misleading red checks. - Replace remaining str_contains() calls in src/Parse/CreateTable.php with strpos(...) !== false. str_contains() is PHP 8.0+ but the project requires php ^7.2; the lowest-resolution matrix has no symfony/polyfill-php80 transitively, so these crashed at runtime. - Functional-tests job needs vendor/ on the host because the morphism container mounts the repo at /srv. Added a Setup PHP + composer install step before invoking make test-functional. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Commit c97c569 ("charset & collation diff utf8mb3 as utf8") added utf8mb3 -> utf8 normalization to setCollation() but not to setCharset(). MySQL 8's mysqldump emits CHARSET=utf8mb3 at the table level and COLLATE utf8_general_ci at the column level, which produced a "COLLATION 'utf8_general_ci' is not valid for CHARACTER SET 'utf8'" failure when morphism lint parsed its own dump. Mirror the existing collation-side normalization in setCharset so both halves agree. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps phpunit/phpunit from 7.5.20 to 8.5.52.
Release notes
Sourced from phpunit/phpunit's releases.
... (truncated)
Changelog
Sourced from phpunit/phpunit's changelog.
... (truncated)
Commits
1015741Prepare release3141742Do not run PHPT test when its temporary file for code coverage information ex...0b3170aWe do not need to unserialize() objects here261086aExtract methodfdd6b86Fix CS/WS issueb4f79fcFixe4eee30Prepare release22b2b0bUpdate dependencies0b19865Update tools04ecd72Update toolsDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.