Skip to content

fix: expose multi-value Apply button to assistive technology - #1643

Open
LouisDeconinck wants to merge 1 commit into
grafana:mainfrom
LouisDeconinck:fix/adhoc-apply-button-a11y-1600
Open

fix: expose multi-value Apply button to assistive technology#1643
LouisDeconinck wants to merge 1 commit into
grafana:mainfrom
LouisDeconinck:fix/adhoc-apply-button-a11y-1600

Conversation

@LouisDeconinck

Copy link
Copy Markdown

Fixes #1600

Summary

The multi-value ad hoc filter Apply button is rendered as a sibling of the floating dropdown. Floating UI therefore marks its wrapper as aria-hidden, and the explicit tabIndex=-1 prevents keyboard users from reaching it.

This change:

  • registers the Apply button wrapper with Floating UI getInsideElements so it remains in the accessibility tree;
  • restores the button native tab stop.

Validation

  • corepack yarn workspace @grafana/scenes test src/variables/adhoc/AdHocFiltersVariable.test.tsx --watch=false --runInBand (362 passed)
  • corepack yarn workspace @grafana/scenes typecheck
  • corepack yarn workspace @grafana/scenes lint
  • corepack yarn workspace @grafana/scenes build
  • Prettier check on all changed files
  • git diff --check

@LouisDeconinck
LouisDeconinck requested a review from a team as a code owner September 10, 2026 18:00
@LouisDeconinck
LouisDeconinck requested review from Sergej-Vlasov and kristinademeshchik and removed request for a team September 10, 2026 18:00
@github-actions

github-actions Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Signed commits report

All 1 commit between main and fix/adhoc-apply-button-a11y-1600 have verified signatures. ✅

@cla-assistant

cla-assistant Bot commented Sep 10, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

Signed-off-by: Louis Deconinck <louis.dck@gmail.com>
Assisted-by: Codex
@LouisDeconinck
LouisDeconinck force-pushed the fix/adhoc-apply-button-a11y-1600 branch from f3f0347 to 0fb5c44 Compare September 11, 2026 05:27
@LouisDeconinck

Copy link
Copy Markdown
Author

I've completed the Grafana CLA and updated the branch with a verified signed commit. Thanks — happy to address any review feedback.

@Sergej-Vlasov

Copy link
Copy Markdown
Contributor

@LouisDeconinck thank you for the contribution! Squad will review this ASAP!
@samjewell could you give this a local test to see if it fully fixes your issue?

@Sergej-Vlasov Sergej-Vlasov added patch Increment the patch version when merged release Create a release when this pr is merged labels Sep 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

patch Increment the patch version when merged release Create a release when this pr is merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AdHocFiltersCombobox: multi-value "Apply" button is hidden from assistive technology

2 participants