fix: expose multi-value Apply button to assistive technology - #1643
Open
LouisDeconinck wants to merge 1 commit into
Open
fix: expose multi-value Apply button to assistive technology#1643LouisDeconinck wants to merge 1 commit into
LouisDeconinck wants to merge 1 commit into
Conversation
LouisDeconinck
requested review from
Sergej-Vlasov and
kristinademeshchik
and removed request for
a team
September 10, 2026 18:00
Contributor
Signed commits reportAll 1 commit between |
Signed-off-by: Louis Deconinck <louis.dck@gmail.com> Assisted-by: Codex
LouisDeconinck
force-pushed
the
fix/adhoc-apply-button-a11y-1600
branch
from
September 11, 2026 05:27
f3f0347 to
0fb5c44
Compare
Author
|
I've completed the Grafana CLA and updated the branch with a verified signed commit. Thanks — happy to address any review feedback. |
Contributor
|
@LouisDeconinck thank you for the contribution! Squad will review this ASAP! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1600
Summary
The multi-value ad hoc filter Apply button is rendered as a sibling of the floating dropdown. Floating UI therefore marks its wrapper as aria-hidden, and the explicit tabIndex=-1 prevents keyboard users from reaching it.
This change:
Validation