Skip to content

refactor: use += for period, samples, and count accumulation #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
maayanmatsliah-tech wants to merge 1 commit into from
Closed

refactor: use += for period, samples, and count accumulation #302

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/mx/_impl/mx_proftool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1185,8 +1185,8 @@ def merge_perf_events(self):
for event in self.events:
e = events_by_address.get(event.pc)
if e:
e.period = e.period + event.period
e.samples = e.samples + event.samples
e.period += event.period
e.samples += event.samples
else:
# avoid mutating the underlying raw event
events_by_address[event.pc] = copy.copy(event)
Expand All @@ -1201,7 +1201,7 @@ def get_top_methods(self):
count = hot_symbols.get(key)
if count is None:
count = 0
count = count + event.period
count += event.period
hot_symbols[key] = count
entries = [(s, d, c) for (s, d), c in hot_symbols.items()]

Expand Down