Conversation
…xtension build issues
…ermaid, typeql (and possibly others) for building schema visualization and other DX related tools
…mb-web for schema visualization support
…n quoomb-web, fix "ESLint couldn't find an eslint.config.(js|mjs|cjs) file" issue.
…ript preset support
n8allan
requested changes
May 22, 2026
n8allan
left a comment
n8allan
left a comment
Contributor
There was a problem hiding this comment.
This brings in a lot of package dependencies. I like the feature, but it does make me a little nervous in the current climate of npm worms. The alternative, I suppose, would be to introduce extensibility and contribution points to quoomb web, which seems like overkill at this stage. I'm torn...
|
|
||
| resolve: { | ||
| alias: [ | ||
| { |
Contributor
There was a problem hiding this comment.
We've been using workspace:^ for intra-workspace references. See other packages for an example.
Contributor
|
VS Code just added Mermaid. I guess that puts us in pretty good company as far as vulnerabilities go. |
… alias Drop the source-path vite alias and rely on the workspace:^ dependency declared in package.json, matching how other intra-workspace @quereus/* packages are consumed. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Author
|
# Conflicts: # packages/quereus-vscode/package.json # yarn.lock
…eact-markdown-mermaid ERDPanel only used react-markdown-mermaid's MermaidBlock/MermaidService to render a single diagram from a string — none of its markdown features. Replace with a small local MermaidDiagram component calling mermaid's render API. Removes the react-markdown-mermaid@0.0.3 dependency (a thin, low-version wrapper) and the duplicate mermaid v10 it pinned (the project depends on v11 directly), trimming ~24 unused unified/rehype/hast markdown packages from the transitive tree and shrinking the closure from 123 to ~98. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…wser build Bring quoomb-web up to date with the engine/store APIs surfaced by the main merge so it typechecks and builds end-to-end again. - worker: drop the duplicate `import * as Comlink` line, and add the imports the code already used but never declared — IndexedDBProvider/IndexedDBStore from @quereus/plugin-indexeddb and dynamicLoadModule from @quereus/plugin-loader (both already direct deps). Remove the now-unused DatabaseDataChangeEvent / DatabaseSchemaChangeEvent type imports that tripped lint. - sessionStore: createTabActions takes only `set`; stop passing the extra `get`. - .yarnrc.yml: langium (transitive via mermaid -> @mermaid-js/parser) imports vscode-jsonrpc, vscode-languageserver-protocol and vscode-languageserver-types without declaring them, breaking the vite/rollup browser build under Yarn PnP's strict resolution. Declare them on langium via packageExtensions so the fix is reproducible on fresh / CI (--immutable) installs. - .gitignore: stop ignoring .yarnrc.yml so the packageExtensions are tracked alongside the committed .pnp.cjs (verified with `yarn install --immutable`).
Author
Mermaid and its transitive deps are the only new dependencies now. |
Brings the ER-diagram branch up to date with main (v4.11.0). Conflict resolutions: - package.json: took main's bumpp/esbuild/rimraf bumps, kept the root ts-node the vscode-extension work added. - quoomb-web/package.json: took main's dexie/lucide-react versions, kept the mermaid and @quereus/babel-fish deps. - quereus-vscode/package.json: took main's esbuild/rimraf bumps, kept @types/vscode ^1.109.0 so it stays aligned with engines.vscode (the extension-install compatibility fix). - quereus-vscode/README.md: kept the manual build steps, in main's formatting. - quoomb-web worker: unioned the import blocks — main's sync maintenance ticker / held-changes-drain symbols plus this branch's indexeddb and plugin-loader imports, with the duplicate ./types.js import dropped. - shared-ui/tsconfig.tsbuildinfo: accepted main's deletion (build output). - yarn.lock: regenerated from main's. Also wires @quereus/babel-fish into the build the way main now does it: main replaced the hand-ordered build:* chain with `tsc -b tsconfig.build.json`, so babel-fish becomes a composite project referencing packages/quereus and is listed in tsconfig.build.json. Without this the web build cannot resolve @quereus/babel-fish. Its tsconfig paths overrides into quereus/src are dropped in favour of the project reference, matching the other library packages. Verified: yarn build, yarn docs:check, quoomb-web and babel-fish typechecks, and the vitest/mocha suites that run in this tree.
…tifacts This branch was the only thing putting the repo in Yarn PnP mode: it began tracking .yarnrc.yml, .pnp.cjs and .pnp.loader.mjs, all three of which main gitignores. PnP is not a working configuration for this repo — every mocha based test script invokes `node_modules/mocha/bin/mocha.js` by literal path, and each package's register.mjs registers ts-node/esm anchored at the workspace root. Under PnP that surfaces as `Cannot find module .../node_modules/mocha/bin/mocha.js` in the store/sync/isolation suites, as spurious "Cannot find name 'describe'" type errors in the engine suite, and as an undeclared-@eslint/js failure in `yarn lint`. Pin nodeLinker: node-modules so a fresh clone of the branch installs the way main is developed, and drop the generated .pnp.* files from the index. The langium packageExtensions stay: hoisting covers those undeclared imports today, but keeping them documented means the mermaid browser build survives a stricter install. yarn lint, yarn build, yarn typecheck, yarn docs:check and yarn test all run clean again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preview:
