Add PSR-11 container interface methods to TracingResolver - #11
Merged
Merged
Conversation
The upstream axiom package now has BindableResolver extending PSR-11's ContainerInterface. This adds the required get() and has() methods to TracingResolver, delegating to the inner resolver. https://claude.ai/code/session_012JM3NBW2w7F9vhGSmrMWuf
Already provided transitively via gosuperscript/axiom ^0.3.3. https://claude.ai/code/session_012JM3NBW2w7F9vhGSmrMWuf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for PSR-11 container interface methods (
get()andhas()) to theTracingResolverclass, enabling it to be used as a drop-in replacement for any PSR-11 compatible container.Changes
get(string $id): mixedmethod - Delegates to the inner resolver'sget()method to retrieve a service by its identifierhas(string $id): boolmethod - Delegates to the inner resolver'shas()method to check if a service is registeredpsr/container: ^2.0as an explicit dependency to support the PSR-11 interfaceImplementation Details
Both methods are simple delegation methods that pass through to the inner resolver without any tracing overhead, maintaining the existing pattern used by other delegation methods in the class. This allows the
TracingResolverto maintain full compatibility with the PSR-11ContainerInterfacewhile preserving its tracing capabilities for resolution operations.https://claude.ai/code/session_012JM3NBW2w7F9vhGSmrMWuf