Open
Conversation
product-auto-label
bot
added
size: m
sycai
reviewed
Mar 18, 2026
| self._cached_executions: weakref.WeakKeyDictionary[ | ||
| nodes.BigFrameNode, bq_data.BigqueryDataSource | ||
| ] = weakref.WeakKeyDictionary() | ||
| # This is state, but probably should be handled by some storage manager rather than by the general plan caching? |
Contributor
There was a problem hiding this comment.
typo nit: "This is state" -> "This is stateful" ?
Also, if we feel like there are unresolved issues with the current implementation, we'd better open a bug and put more details there, then link that bug with a TODO(b/12345)
| ] = weakref.WeakKeyDictionary() | ||
|
|
||
| def subsitute_cached_subplans(self, root: nodes.BigFrameNode) -> nodes.BigFrameNode: | ||
| def maybe_replace_node(node): |
Contributor
There was a problem hiding this comment.
naming nit: I would just call this function "replace_node()"
|
|
||
| @dataclasses.dataclass(frozen=True) | ||
| class ExecutionSpec: | ||
| # This could probably be a set of side effects, rather than a single destination_spec |
Contributor
There was a problem hiding this comment.
Consider making this a formal TODO with a bug number, because the current comment does not give out much information. Or we can simply remove the comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕