fix: prevent test.db from being created during unit tests#3042
Open
fix: prevent test.db from being created during unit tests#3042
Conversation
helloeve
changed the title
helloeve
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the TestInvokeTool function in cmd/internal/invoke/command_test.go to use a dynamic temporary directory for the SQLite database path instead of a hardcoded file. The review feedback suggests wrapping the database path in single quotes within the YAML configuration to ensure it is parsed correctly if the path contains spaces or special characters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the unit tests to use in-memory SQLite databases (:memory:) instead of creating physical test.db files on disk.
While using tmp directory for managing the test.db file is a plausible approach, it will encounter file-locking conflicts on Windows during test cleanup which prevents the clean-up of database files located in tmp directory.