feat: add Columnar Engine, Auto-Columnarization, and Vector Assist op… - #629
Open
madamsetty-pavan wants to merge 12 commits into
Open
feat: add Columnar Engine, Auto-Columnarization, and Vector Assist op…#629madamsetty-pavan wants to merge 12 commits into
madamsetty-pavan wants to merge 12 commits into
Conversation
…timizations - Add enable_columnar_engine and aenable_columnar_engine - Add enable_auto_columnarization and aenable_auto_columnarization - Add Vector Assist spec definition, application, and recommendations - Add initialize_auto_vector_embeddings for automated embedding generation - Add comprehensive sync and async unit tests with detailed comments
product-auto-label
Bot
added
the
api: alloydb
…ist (NB-1, NB-2, NB-3, NB-6, Finding 1, 2, 5)
…ist (NEW-1, NEW-2, NEW-3, NEW-4, NB-6)
…ist (BUG-2, NEW-2.1/2, NEW-4.1, NEW-6.1, DOC-1)
…ecycle (R5-BUG-1/3, NEW-2.1, NEW-6.1, BUG-2 part 2, NEW-5-BUG-1/2, DOC-1)
zhou0ricky
reviewed
Sep 3, 2026
| schema_name (str): The schema name of the table. Default: "public". | ||
| """ | ||
| await self._run_as_async( | ||
| self._adrop_table(table_name=table_name, schema_name=schema_name) |
There was a problem hiding this comment.
Is _adrop_table implemented anywhere?
zhou0ricky
reviewed
Sep 3, 2026
| params = "WITH " + index.index_options() | ||
| if name is None: | ||
| if index.name is None: | ||
| index.name = self.table_name + DEFAULT_INDEX_NAME_SUFFIX |
There was a problem hiding this comment.
Not sure if index.name is ever used elsewhere, but just confirming that index.name mutation is intentional.
zhou0ricky
approved these changes
Sep 3, 2026
zhou0ricky
left a comment
zhou0ricky
left a comment
There was a problem hiding this comment.
Added a few comments, otherwise should be good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: add Columnar Engine, Auto-Columnarization, and Vector Assist optimizations