-
Notifications
You must be signed in to change notification settings - Fork 2.5k
chore: replace old python teams with cloud-sdk-python-team #2711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @suztomo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request centralizes the ownership and assignment of Python-related tasks and code within the repository. By replacing several older Python teams with a single Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request replaces old Python team names with @googleapis/cloud-sdk-python-team in the repository's configuration files. The changes are generally correct, but I've pointed out a couple of places in the CODEOWNERS file where the new team name is duplicated, which should be cleaned up for better maintainability.
.github/CODEOWNERS
Outdated
|
|
||
| # Default owners for changes in this repo | ||
| * @googleapis/yoshi-python @googleapis/python-core-client-libraries | ||
| * @googleapis/cloud-sdk-python-team @googleapis/cloud-sdk-python-team |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.github/CODEOWNERS
Outdated
|
|
||
| # For more information, see https://github.com/googleapis/repo-automation-bots/blob/main/packages/auto-approve/README.md | ||
| .github/auto-approve.yml @googleapis/python-core-client-libraries @googleapis/yoshi-python | ||
| .github/auto-approve.yml @googleapis/cloud-sdk-python-team @googleapis/cloud-sdk-python-team |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e9c2f14 to
80c8f1d
Compare
Bug ID: b/479543683