-
Notifications
You must be signed in to change notification settings - Fork 1.1k
fix(tools/looker): Looker client OAuth nil pointer error #2231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @duwenxin99, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical bug related to Looker client OAuth, where an uninitialized Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to fix a nil error related to Looker client OAuth. However, the proposed change introduces a compilation error by attempting to set an unexported field on a struct from an external package, and it also misses the required import. My review includes a critical comment explaining why the change is invalid and suggests investigating a dependency update as a more robust solution.
…2231) The original implementation initializes auth session using direct struct creation `&rtl.AuthSession` which does not have a source field initialized, causing nil pointer error when the sdk is trying to access this source field. This is fixed by using the`NewAuthSession()` constructor which automatically initializes a source field. Fix: googleapis#2230 --------- Co-authored-by: Dr. Strangelove <[email protected]>
The original implementation initializes auth session using direct struct creation
&rtl.AuthSessionwhich does not have a source field initialized, causing nil pointer error when the sdk is trying to access this source field. This is fixed by using theNewAuthSession()constructor which automatically initializes a source field.Fix: #2230