Skip to content

Conversation

@duwenxin99
Copy link
Contributor

@duwenxin99 duwenxin99 commented Dec 23, 2025

The original implementation initializes auth session using direct struct creation &rtl.AuthSession which does not have a source field initialized, causing nil pointer error when the sdk is trying to access this source field. This is fixed by using theNewAuthSession() constructor which automatically initializes a source field.
Fix: #2230

@duwenxin99 duwenxin99 requested a review from a team as a code owner December 23, 2025 16:35
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @duwenxin99, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug related to Looker client OAuth, where an uninitialized source field in the authentication session was causing a nil error. The change ensures that the OAuth token is correctly passed and utilized, allowing the Looker SDK to properly authenticate and operate when client OAuth is enabled, thereby fixing the reported issue.

Highlights

  • Looker Client OAuth Fix: Resolved a nil error that occurred when using Looker client OAuth by ensuring the source field within the rtl.AuthSession is properly initialized with an oauth2.StaticTokenSource.
  • Authentication Session Initialization: Explicitly set the source for the AuthSession to use the provided accessToken, preventing a runtime error during SDK creation.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to fix a nil error related to Looker client OAuth. However, the proposed change introduces a compilation error by attempting to set an unexported field on a struct from an external package, and it also misses the required import. My review includes a critical comment explaining why the change is invalid and suggests investigating a dependency update as a more robust solution.

@duwenxin99 duwenxin99 changed the title fix: Looker client OAuth nil error fix(tools/looker): Looker client OAuth nil pointer error Dec 23, 2025
@drstrangelooker drstrangelooker enabled auto-merge (squash) January 6, 2026 17:31
@drstrangelooker drstrangelooker merged commit 268700b into main Jan 6, 2026
12 checks passed
@drstrangelooker drstrangelooker deleted the looker-auth branch January 6, 2026 17:51
ravisiddhu pushed a commit to ravisiddhu/genai-toolbox that referenced this pull request Jan 8, 2026
…2231)

The original implementation initializes auth session using direct struct
creation `&rtl.AuthSession` which does not have a source field
initialized, causing nil pointer error when the sdk is trying to access
this source field. This is fixed by using the`NewAuthSession()`
constructor which automatically initializes a source field.
Fix: googleapis#2230

---------

Co-authored-by: Dr. Strangelove <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Looker giving 500 error when using user Oauth

4 participants