feat(sources/trino): add ssl verification options and fix docs example #2155
Conversation
Summary of ChangesHello @gRedHeadphone, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the Trino source integration by adding flexible SSL verification options, including the ability to specify custom SSL certificates or disable verification for development/testing environments. Concurrently, it refines the Trino SQL documentation to correctly illustrate the parameter placeholder syntax, ensuring clearer guidance for users constructing prepared statements. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds SSL verification options to the Trino source and updates the documentation for Trino SQL parameters. The changes are generally good, but I've identified a couple of issues in internal/sources/trino/trino.go related to security and code correctness that should be addressed. Specifically, there's a need to log a warning when insecure SSL settings are used, and to handle potential errors during configuration reloads. I've also noted a minor regression in OpenTelemetry context propagation.
|
@gRedHeadphone Thank you for opening this PR. :) Please let me know if you need more clarifications, thank you! |
Yuan325
changed the title
Yuan325
left a comment
Yuan325
left a comment
There was a problem hiding this comment.
Thank you for the contribution! :)
|
🧨 Preview deployments removed. |
…s example (#2155) ## Description Adds options such as disableSslVerification, sslCert and sslCertPath to trino source. Also fixes trino-sql docs on params ## PR Checklist - [x] Make sure you reviewed [CONTRIBUTING.md](https://github.com/googleapis/genai-toolbox/blob/main/CONTRIBUTING.md) - [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/genai-toolbox/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [x] Ensure the tests and linter pass - [x] Code coverage does not decrease (if any source code was changed) - [x] Appropriate docs were updated (if necessary) - [x] Make sure to add `!` if this involve a breaking change 🛠️ Fixes #1910 --------- 4a4cf1e
…s example (googleapis#2155) ## Description Adds options such as disableSslVerification, sslCert and sslCertPath to trino source. Also fixes trino-sql docs on params ## PR Checklist - [x] Make sure you reviewed [CONTRIBUTING.md](https://github.com/googleapis/genai-toolbox/blob/main/CONTRIBUTING.md) - [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/genai-toolbox/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [x] Ensure the tests and linter pass - [x] Code coverage does not decrease (if any source code was changed) - [x] Appropriate docs were updated (if necessary) - [x] Make sure to add `!` if this involve a breaking change 🛠️ Fixes googleapis#1910 --------- 4a4cf1e
…s example (googleapis#2155) ## Description Adds options such as disableSslVerification, sslCert and sslCertPath to trino source. Also fixes trino-sql docs on params ## PR Checklist - [x] Make sure you reviewed [CONTRIBUTING.md](https://github.com/googleapis/genai-toolbox/blob/main/CONTRIBUTING.md) - [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/genai-toolbox/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [x] Ensure the tests and linter pass - [x] Code coverage does not decrease (if any source code was changed) - [x] Appropriate docs were updated (if necessary) - [x] Make sure to add `!` if this involve a breaking change 🛠️ Fixes googleapis#1910 --------- 4a4cf1e
googleapis#2155) ## Description Adds options such as disableSslVerification, sslCert and sslCertPath to trino source. Also fixes trino-sql docs on params ## PR Checklist - [x] Make sure you reviewed [CONTRIBUTING.md](https://github.com/googleapis/genai-toolbox/blob/main/CONTRIBUTING.md) - [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/genai-toolbox/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [x] Ensure the tests and linter pass - [x] Code coverage does not decrease (if any source code was changed) - [x] Appropriate docs were updated (if necessary) - [x] Make sure to add `!` if this involve a breaking change 🛠️ Fixes googleapis#1910 ---------
…s example (googleapis#2155) ## Description Adds options such as disableSslVerification, sslCert and sslCertPath to trino source. Also fixes trino-sql docs on params ## PR Checklist - [x] Make sure you reviewed [CONTRIBUTING.md](https://github.com/googleapis/genai-toolbox/blob/main/CONTRIBUTING.md) - [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/genai-toolbox/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [x] Ensure the tests and linter pass - [x] Code coverage does not decrease (if any source code was changed) - [x] Appropriate docs were updated (if necessary) - [x] Make sure to add `!` if this involve a breaking change 🛠️ Fixes googleapis#1910 --------- 4a4cf1e
…s example (googleapis#2155) ## Description Adds options such as disableSslVerification, sslCert and sslCertPath to trino source. Also fixes trino-sql docs on params ## PR Checklist - [x] Make sure you reviewed [CONTRIBUTING.md](https://github.com/googleapis/genai-toolbox/blob/main/CONTRIBUTING.md) - [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/genai-toolbox/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [x] Ensure the tests and linter pass - [x] Code coverage does not decrease (if any source code was changed) - [x] Appropriate docs were updated (if necessary) - [x] Make sure to add `!` if this involve a breaking change 🛠️ Fixes googleapis#1910 --------- 4a4cf1e
2 participants
Description
Adds options such as disableSslVerification, sslCert and sslCertPath to trino source. Also fixes trino-sql docs on params
PR Checklist
CONTRIBUTING.md
bug/issue
before writing your code! That way we can discuss the change, evaluate
designs, and agree on the general idea
!if this involve a breaking change🛠️ Fixes #1910