build: Update benchmark submodule for RISC-V#208
Merged
danilak-G merged 1 commit intogoogle:mainfrom Jul 29, 2025
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
- Pins to b20cea67 to fix illegal instruction - Verified on openEuler RISC-V
fe833c8 to
b68435f
Compare
Contributor
Author
|
Hi @haney , this is my first contribution to the project. Could you please approve running the CI workflow? Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes RISC-V Illegal Instruction Error
Problem
snappy_benchmarkcrashes on RISC-V platforms due to:rdcycleinstruction in older Google Benchmark versionsrdcyclein userspaceSolution
Update benchmark submodule to
b20cea67which:rdtimeinstruction (userspace-safe)Testing