feat(yeti): let the agents chat offer a choice of Gemini models - #281
Merged
Merged
Conversation
The chart set GEMINI_MODEL, the model a conversation uses when none is chosen, but not GEMINI_MODELS, the set a user may choose between. Without the second the chat UI has one option and hides its selector, so the picker added in yeti-agents#10 could not be reached from a Helm deployment at all. The default list is deliberately short. It is what a deployment is willing to spend quota on rather than everything the provider publishes, which is the point of choosing: the usual reason is that one model is throttling. gemini-3.1-pro-preview is included because it is the only Pro in that line -- there is no gemini-3.1-pro -- and noted as a preview in values.yaml, since those are retired on Google's schedule rather than ours.
Two settings described the same thing and could disagree, with nothing stopping a deployment defaulting to a model it did not offer. yeti-agents#11 takes the default from the head of the list, so ordering geminiModels by preference says both things at once. Deployments that set agents.geminiModel keep working: the service still honours GEMINI_MODEL where it is set, it is simply no longer something this chart writes.
Collaborator
Author
|
Pushed a follow-up now that yeti-platform/yeti-agents#11 has merged: Two settings described the same thing and could disagree — nothing stopped a deployment defaulting to a model it did not offer. Ordering the list by preference says both things at once: geminiModels:
- gemini-3.7-flash # <- used unless a conversation picks another
- gemini-3.5-flash
- gemini-3.5-flash-lite
- gemini-3.1-pro-previewRendered env is now just: and fed to Nothing breaks for anyone setting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The chart sets
GEMINI_MODEL— the model a conversation uses when none is chosen — but notGEMINI_MODELS, the set a user may pick from. yeti-agents#10 added a model picker to the chat, and the UI hides the selector when only one model is offered, so the feature is unreachable from a Helm deployment.Change
rendered as a comma-separated
GEMINI_MODELS, and omitted entirely when the list is empty so the service falls back to offering justgeminiModel.The list is deliberately short. It is what the deployment is willing to spend quota on, not everything the provider publishes — the usual reason to switch models is that one is throttling, so the set wants to be a considered one.
geminiModelis always available whether or not it appears in the list.On
gemini-3.1-pro-previewThere is no
gemini-3.1-pro; the only Pro in that line is the preview. It is included because Pro is worth having available, and flagged invalues.yamlas a preview — those are retired on Google's schedule, so one listed here can stop working with no change on this side. That is also why the default stays on a stable id.Verified
helm lintpasses. Rendered:and fed that exact string to
yetiplatform/yeti-agents:dev, which parses it as intended:Chart versions bumped to
yeti 2.8.0/osdfir-infrastructure 2.14.0,Chart.lockregenerated.