Remove --timeout/--restricted from renderer#1494
Open
yukawa wants to merge 1 commit intogoogle:masterfrom
Open
Remove --timeout/--restricted from renderer#1494yukawa wants to merge 1 commit intogoogle:masterfrom
--timeout/--restricted from renderer#1494yukawa wants to merge 1 commit intogoogle:masterfrom
Conversation
As part of our ongoing effort to deprecate restricted mode (google#1376), we are removing the --timeout and --restricted flags from mozc_renderer. These flags had actually used only in Windows until recently, but with the recent commit [1] there remains no code path that specifies these flags. Therefore we can safely remove these unused flags and the related code. [1]: ca34c8d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As part of our ongoing effort to deprecate restricted mode, we are removing the
--timeoutand--restrictedflags frommozc_renderer.These flags had actually used only in Windows until recently, but with the recent commit (ca34c8d) there remains no code path that specifies these flags. Therefore we can safely remove these unused flags and the related code.
Issue IDs
mozc_serverandmozc_rendereron Windows #1376Steps to test new behaviors (if any)