Add a new lit component <extra-model> which will console.log a message when it's being added to <model-viewer>#4904
Open
samaneh-kazemi wants to merge 24 commits intomasterfrom
Open
Add a new lit component <extra-model> which will console.log a message when it's being added to <model-viewer>#4904samaneh-kazemi wants to merge 24 commits intomasterfrom
samaneh-kazemi wants to merge 24 commits intomasterfrom
Conversation
…ing options declerative
elalish
reviewed
Oct 17, 2024
| import {ContextLostEvent, Renderer} from './three-components/Renderer.js'; | ||
| import {clamp, debounce} from './utilities.js'; | ||
| import {ProgressTracker} from './utilities/progress-tracker.js'; | ||
| import { ReactiveElement } from 'lit'; |
Contributor
There was a problem hiding this comment.
Looks like your formatter isn't set up to use our .clang-format style. Can you fix that to clean up this diff?
Collaborator
Author
There was a problem hiding this comment.
had to do it manually, somehow vscode doesn't pick that for me:
./node_modules/.bin/clang-format -i packages/model-viewer/src/model-viewer-base.ts
…el-viewer-base.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issue