Skip to content

fix(brand-search-optimization): upgrade to google-adk 2.13.0 and remove Computer Use alias workarounds - #2827

Merged
happyhuman merged 2 commits into
google:mainfrom
anaelledrai:fix/brand-search-optimization-adk-2-13-computer-use
Oct 27, 2026
Merged

happyhuman merged 2 commits into
google:mainfrom
anaelledrai:fix/brand-search-optimization-adk-2-13-computer-use

Conversation

@anaelledrai

@anaelledrai anaelledrai commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Upgrades the brand-search-optimization recipe to google-adk 2.13.0 (which natively supports Gemini 3.x Computer Use short-verb action schemas in ComputerUseToolset) and removes the legacy tool-aliasing workarounds.

Key Changes

  • Removed legacy before_model_callback workaround (app/sub_agents/search_results/agent.py): Deleted _TOOL_NAME_ALIASES and adapt_computer_use_tools_callback now that ComputerUseToolset._build_modern_alias_methods natively registers Gemini 3.x short-verb actions (click, move, type, scroll, take_screenshot, press_key, hotkey).
  • Restored clean BaseComputer signatures (app/tools/browser_computer.py):
    • Restored standard BaseComputer parameter order and signatures on MockBrowserComputer and PlaywrightBrowserComputer (including scroll_at(self, x: int, y: int, direction: Literal["up", "down", "left", "right"], magnitude: int = DEFAULT_SCROLL_OFFSET)).
    • Implemented type_text(self, text: str, press_enter: bool = False) on both computer implementations to support ComputerUseToolset's native type shim directly without falling back to per-character key_combination calls, and reused type_text inside PlaywrightBrowserComputer.type_text_at.
  • Upgraded lockfile & dependencies (uv.lock, pyproject.toml, app/app_utils/reasoning_engine_adapter.py, deployment/deploy.py):
    • Locked google-adk==2.13.0 and google-cloud-aiplatform==2.6.0 (uv lock --python 3.11).
    • Updated AdkApp import in reasoning_engine_adapter.py to vertexai.agent_engines.templates.adk.
    • Added testpaths = ["tests"] to [tool.pytest.ini_options] in pyproject.toml.
  • Expanded unit tests (tests/unit/test_tools.py): Verified all 7 native Gemini 3.x short-verb tools are registered by ComputerUseToolset and tested scroll_at / type_text execution on PlaywrightBrowserComputer.

Verification

  • uv run pytest (23 passed)
  • uv run python tools/validate.py contrib/python/brand-search-optimization (Manifest, Structure, README, Placement passed)
  • uv tool run ruff@0.16.8 format --check & ruff@0.16.8 check (all passed)
  • .agents/skills/make-python-recipe-deployable/scripts/make_deployable.py (all passed)

@anaelledrai
anaelledrai force-pushed the fix/brand-search-optimization-adk-2-13-computer-use branch from af9876c to 3faeb27 Compare October 24, 2026 22:32

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated Maintainability review — 3 finding(s).


Round 1 · 0 of this PR's 25 automated comments used · this round is capped at 20 across all reviewers.

@github-actions github-actions Bot added the status/not-ready-for-review Review requests held until checks pass and bot comments are resolved label Oct 24, 2026
@github-actions

github-actions Bot commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

Ready for review. All checks pass.

Re-requested review from tommywagz.

@anaelledrai
anaelledrai force-pushed the fix/brand-search-optimization-adk-2-13-computer-use branch from 3faeb27 to 1d3f693 Compare October 24, 2026 22:38
@github-actions github-actions Bot removed the status/not-ready-for-review Review requests held until checks pass and bot comments are resolved label Oct 24, 2026
@anaelledrai
anaelledrai force-pushed the fix/brand-search-optimization-adk-2-13-computer-use branch from 1d3f693 to e1c1776 Compare October 27, 2026 17:38
@anaelledrai
anaelledrai force-pushed the fix/brand-search-optimization-adk-2-13-computer-use branch 2 times, most recently from c54412c to 913d422 Compare October 27, 2026 18:32
@anaelledrai
anaelledrai force-pushed the fix/brand-search-optimization-adk-2-13-computer-use branch from 913d422 to cd97b9c Compare October 27, 2026 18:43
@happyhuman
happyhuman merged commit d499106 into google:main Oct 27, 2026
42 checks passed
debanshd added a commit to debanshd/adk-recipes that referenced this pull request Oct 28, 2026
Move to google-adk 2.13.0 with matching google-cloud-aiplatform /
google-cloud-agentplatform 2.6.0 (as main did in google#2827). This removes the
package collision that broke test_web_server_runnability in a fresh
install, and imports AdkApp from vertexai.agent_engines. Bumps certifi to
2026.10.23 (PYSEC-2026-4320) and opentelemetry to 1.44.0, the highest
google-adk 2.13 allows.

Refs google#2810
debanshd added a commit to debanshd/adk-recipes that referenced this pull request Oct 28, 2026
Move to google-adk 2.13.0 with matching google-cloud-aiplatform /
google-cloud-agentplatform 2.6.0 (as main did in google#2827). This removes the
package collision that broke test_web_server_runnability in a fresh
install, and imports AdkApp from vertexai.agent_engines. Bumps certifi to
2026.10.23 (PYSEC-2026-4320) and opentelemetry to 1.44.0, the highest
google-adk 2.13 allows.

Also writes the review patch to a private per-run temp directory and adds
licence headers: Apache for the package markers we wrote, Django's BSD-3
notice for the two vendored upstream files.

Refs google#2811
debanshd added a commit to debanshd/adk-recipes that referenced this pull request Oct 28, 2026
Move to google-adk 2.13.0 with matching google-cloud-aiplatform /
google-cloud-agentplatform 2.6.0 (as main did in google#2827). This removes the
package collision that broke test_web_server_runnability in a fresh
install, and imports AdkApp from vertexai.agent_engines. Bumps certifi to
2026.10.23 (PYSEC-2026-4320) and opentelemetry to 1.44.0, the highest
google-adk 2.13 allows.

Refs google#2812
tommywagz added a commit that referenced this pull request Nov 4, 2026
…ve Computer Use alias workarounds (#2827)

Co-authored-by: Anaelle Drai Laguens <adrailaguens@google.com>
Co-authored-by: Shahin Saadati <happyhuman@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants