Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
Automated House Rules review — 0 finding(s).
Also, on lines this PR does not change:
contrib/python/brand-search-optimization/app/shared_libraries/constants.py:24— [MINOR] env read carries a hardcoded default (second argument is a hardcoded default); 7 occurrence(s) across 1 file(s). Defaults belong in .env.example, not in the code (contrib/python/brand-search-optimization/app/shared_libraries/constants.py:24; and 5 more)
| PROJECT = os.getenv("GOOGLE_CLOUD_PROJECT", "EMPTY") | ||
| LOCATION = os.getenv("GOOGLE_CLOUD_LOCATION", "global") | ||
| MODEL = os.getenv("MODEL") | ||
| MODEL = os.getenv("MODEL", "gemini-3.7-flash") |
Contributor
There was a problem hiding this comment.
[MINOR] Can we keep the fallback default in .env.example and read MODEL without an inline default? Hardcoded model defaults in code split configuration between source and environment files.
| "google-adk>=2.6.0,<3.0.0", | ||
| "google-cloud-aiplatform[agent_engines]>=1.93.0", | ||
| "google-adk>=2.12.0,<3.0.0", | ||
| "google-cloud-aiplatform[agent-engines]>=1.156.0,<2.0.0", |
Contributor
There was a problem hiding this comment.
[MAJOR] Perhaps this should be agent_engines instead of agent-engines? The package extra uses an underscore.
…number (#2563) Co-authored-by: tommywagz <64981171+tommywagz@users.noreply.github.com>
…talog scanner (#2829) Co-authored-by: Gabriela Hernandez Larios <gabrielahl@google.com> Co-authored-by: Shahin Saadati <happyhuman@users.noreply.github.com>
…ve Computer Use alias workarounds (#2827) Co-authored-by: Anaelle Drai Laguens <adrailaguens@google.com> Co-authored-by: Shahin Saadati <happyhuman@users.noreply.github.com>
Co-authored-by: Gabriela Hernandez Larios <gabrielahl@google.com>
…unt (Cloud Shell) (#2849)
…rs; the web app always starts (#2850)
…ents-cli command (#2853)
Co-authored-by: tommywagz <64981171+tommywagz@users.noreply.github.com>
… after Enter (#2854) Co-authored-by: tommywagz <64981171+tommywagz@users.noreply.github.com>
… video checks, Animate (#2855)
…ed by setup-infra, wait for new APIs (#2859)
…download, shorter README (#2860)
tommywagz
requested review from
a team,
eliasecchig,
giuliosalierno,
happyhuman,
lspataroG and
maxgasztych
as code owners
November 4, 2026 15:01
Contributor
|
This PR changes 1430 files, above the 300 GitHub's diff API will serve, so automated AI review was skipped. Splitting it up would get each part reviewed. |
Collaborator
Author
|
Depricated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the dependency conflict between Agents CLI and the brand-search-optimization agent; primarily the google-adk and aiplatform packages. Pictured below -
If this PR is approved I will raise another one updating the remainder of the recipes to use these dependencies.