Repository navigation
feat(contrib): add finops-zero-trust-governor recipe and finops plugin - #2824
varmaleena wants to merge 6 commits into
Conversation
There was a problem hiding this comment.
Automated Security review — 5 finding(s).
contrib/python/finops-zero-trust-governor/README.md
Splitting the PR up would get them reviewed.
Round 1 · 0 of this PR's 25 automated comments used · this round is capped at 20 across all reviewers.
| "ZERO_TRUST_TOKENINFO_URL", | ||
| "https://oauth2.googleapis.com/tokeninfo", | ||
| ) | ||
| req_url = f"{tokeninfo_url}?access_token={access_token}" |
There was a problem hiding this comment.
[MAJOR] Passing access_token in query parameters exposes bearer credentials in request logs and proxy histories. Can we send it in an Authorization header instead?
There was a problem hiding this comment.
Automated Hygiene review — 5 finding(s).
contrib/python/finops-zero-trust-governor/README.md
Splitting the PR up would get them reviewed.
Round 1 · 0 of this PR's 25 automated comments used · this round is capped at 20 across all reviewers.
| return VertexAiSessionService( | ||
| project=os.environ.get("GOOGLE_CLOUD_PROJECT"), | ||
| # Runtime-injected agent-engine region, not GOOGLE_CLOUD_LOCATION | ||
| # (which agent.py pins to "global"). |
There was a problem hiding this comment.
[MINOR] comment contradicts agent.py
There was a problem hiding this comment.
Automated Maintainability review — 3 finding(s).
contrib/python/finops-zero-trust-governor/README.md
Splitting the PR up would get them reviewed.
Round 1 · 0 of this PR's 25 automated comments used · this round is capped at 20 across all reviewers.
There was a problem hiding this comment.
Automated Correctness review — 4 finding(s).
contrib/python/finops-zero-trust-governor/README.md
Splitting the PR up would get them reviewed.
Round 1 · 0 of this PR's 25 automated comments used · this round is capped at 20 across all reviewers.
| @echo "Surfacing token-cost-anomaly-triage skill..." | ||
|
|
||
| test: | ||
| cd skills/token-cost-anomaly-triage && uv run pytest |
There was a problem hiding this comment.
[MAJOR] no tests exist in this directory
|
Ready for review. All checks pass. Re-requested review from |
|
Closing alongside #2823. |
Summary
Adds
contrib/python/finops-zero-trust-governor/and companion skill pluginplugins/finops/:SequentialAgentorchestrator coordinatingtelemetry_investigator,remediation_planner, andzero_trust_executor, wrapped withResumabilityConfig(is_resumable=True).gcp_billing_export_v1) with Cloud Trace OpenTelemetry GenAI spans (gen_ai.usage.input_tokens,gen_ai.usage.output_tokens,adk.agent_name) to isolate runaway token burn and over-provisioned Cloud Run instances.before_tool_callback(verify_token_not_revoked) validating token validity prior to state-mutating actions to abort executions if credentials were revoked mid-run.before_model_callback)ResumabilityConfig)Dockerfile,.dockerignore,agents-cli-manifest.yaml, FastAPI server (fast_api_app.py), and A2A agent card endpoints.INTEGRATION_TEST=TRUEto test runnability and governance gates without requiring live GCP credentials.Validation Status
uv run validate contrib/python/finops-zero-trust-governor(PASS: manifest, structure, README, placement)uv run validate plugins/finops(PASS: plugin manifest, structure, placement)uv run python .github/scripts/check_env_vars.py contrib/python/finops-zero-trust-governor(PASS: all 15 variables verified)uv run python .github/scripts/check_recipe_pyproject.py contrib/python/finops-zero-trust-governor(PASS)uv run ruff check .&uv run ruff format --check .(PASS: 0 violations)INTEGRATION_TEST=TRUE uv run pytest -v(PASS: 11/11 tests pass)leevarma2@gmail.com