Skip to content

chore: clean up stale links, docs, and legacy path references across repo - #2760

Merged
happyhuman merged 4 commits into
mainfrom
chore/repo-wide-cleanup
Oct 2, 2026
Merged

happyhuman merged 4 commits into
mainfrom
chore/repo-wide-cleanup

Conversation

@happyhuman

Copy link
Copy Markdown
Collaborator

Summary

  • Documentation & READMEs:
    • Update README.md example paths under plugins/ to plugins/retail/skills/product-search and plugins/retail/skills/virtual-tryon.
    • Update CONTRIBUTING.md to list all three recipe roots (core/, contrib/, and plugins/).
    • Clarify language subfolder layout in core/README.md and contrib/README.md.
    • Update docs/recipe-handbook/anatomy.md, docs/recipe-handbook/troubleshooting.md, and docs/recipe-checklist.md to cover both Agent Plugins v1.0.0 container paths (plugins/<plugin>/plugin.json + skills/<skill>/SKILL.md) and legacy plugins/<vertical>/<solution>.
    • Fix broken notebooks/train_shoe_classifier.ipynb link in core/python/genmedia-for-commerce/.../shoes/README.md to point to infra/model_training/.
    • Fix duplicate ## Makefile Reference heading in core/python/oauth-user-consent-flow/README.md to ## References so the TOC #references anchor resolves.
    • Wrap illustrative links in .github/style.md in code blocks/backticks so link checkers do not treat them as broken relative links.
  • Tooling & CI:
    • Update tools/README.md, tools/validate.py, tools/validate_structure.py, and tools/validate_manifest.py to list all four validator subcommands (manifest, structure, readme, placement), include plugins scope, and use namespaced recipe paths (core/python/rag-agent-search instead of core/rag-agent-search).
    • Update test_real_kotlin_recipe_passes_clean in .github/scripts/tests/test_check_recipe_lint_config.py and comments/fixtures in recipe_images_matrix.py to reference contrib/kotlin/llm-auditor and plugins/retail/skills/virtual-tryon.
    • Remove retired typescript/** path triggers from .github/workflows/typescript-tests.yml and clean up stale legacy comments in .github/dependabot.yml, .github/workflows/java-format.yml, .github/workflows/kotlin-format.yml, and pyproject.toml.


def test_real_kotlin_recipe_passes_clean(monkeypatch, capsys):
kotlin_recipe = REPO_ROOT / "core" / "kotlin" / "llm-auditor"
kotlin_recipe = REPO_ROOT / "contrib" / "kotlin" / "llm-auditor"

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think llm-auditor recipes were just deleted today. check both core and contrib to make sure.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switched this to contrib/kotlin/financial-advisor (note: contrib/kotlin/llm-auditor and contrib/python/llm-auditor are still in contrib/ — only core/kotlin/llm-auditor and python/agents/llm-auditor were moved/deleted — but financial-advisor is the better canonical fixture).

def test_category_disambiguates_same_named_recipes(tmp_path: Path) -> None:
"""core/kotlin/llm-auditor and contrib/python/llm-auditor coexist today."""
_recipe(tmp_path, "core/kotlin/llm-auditor")
"""contrib/kotlin/llm-auditor and contrib/python/llm-auditor coexist today."""

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same. I doubt llm-auditor exists anymore.

@happyhuman happyhuman Oct 2, 2026 •

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switched both recipe_images_matrix.py and test_recipe_images_matrix.py to contrib/kotlin/financial-advisor and contrib/python/financial-advisor.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated Maintainability review — 1 finding(s).


Round 1 · 0 of this PR's 25 automated comments used · this round is capped at 20 across all reviewers.

@happyhuman happyhuman self-assigned this Oct 2, 2026
@happyhuman
happyhuman merged commit b6e9752 into main Oct 2, 2026
44 checks passed
@happyhuman
happyhuman deleted the chore/repo-wide-cleanup branch October 2, 2026 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant